Compare commits

..
6 Commits
Author SHA1 Message Date
Ansho Rei 2ac0c64001 Add the worklane logo and show it in the README, and bump to 0.33.12 2026-11-07 00:42:23 +01:00
Ansho Rei 07ac204829 Ignore sandbox device mounts in the release dirty-tree check, and bump to 0.33.11
An agent sandbox bind-mounts /dev/null over protected paths such as
.bashrc and files inside .claude/, so make patch refused a tree that
was clean outside the sandbox. Untracked character devices cannot be
committed, so the check skips them and lists only what blocks the
release. Untracked files are listed one by one rather than with
--directory, since the collapsed .claude/ entry is not a device.
2026-11-06 18:45:38 +01:00
Ansho Rei 19c666b5dc Close a review of landed work by filing its remaining issues as tickets, and bump to 0.33.10
Work already on the default branch cannot go back to committed without
reopening shipped code. The reviewer files each remaining issue as a new
ticket, related issues together, comments why the ticket is closing, and
moves it to done.
2026-11-06 18:43:07 +01:00
Ansho Rei 8e7a3f1425 Fix tags in tui on narrow screen, and bump to 0.33.9 2026-11-06 17:45:49 +01:00
Ansho ReiandClaude Opus 5 fbd752afc9 (8a7fe6c) Read a flag by either spelling, on the prompt and in the fish rules, and bump to 0.33.8
`:mv --status ` offered the five statuses on the board and `:mv -s `
offered nothing: argument_at read the typed word with strip_prefix("--"),
so a word spelled with one hyphen was not a flag to it and fell through to
the positional arm, which counted a position that was not there.

long_name translates the letter through the command that holds the flag, so
the tables stay keyed on the long name and nothing here keeps a second list
of every option's letter. One letter, never a cluster: `mv -fs done` would
make the last letter the honest answer, but --title, --acceptance and a
comment body all take a leading hyphen on purpose, and a criterion typed as
`-fixes the offset` must not be answered with statuses.

The fish half had the same hole in its dynamic rules alone, which were
written as `-l <flag>`: `append -g <TAB>` offered nothing where
`append --tags <TAB>` offered the board's tags. fish_option reads the letter
off the definition per command, so an option given one tomorrow is offered
under it the day it is given. Clap's own generated rules already carried
both spellings, which is why a shell answered `mv -s ` and the board did
not.

a_short_flag_answers_what_its_long_spelling_answers walks every option with
both spellings on every command and nested command and pins that the two
answer the same, so this cannot come back one flag at a time.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-15 17:00:35 +02:00
Ansho ReiandClaude Opus 5 298e00eb33 (d7e493e) Draw the command's own usage line while the prompt is open, and bump to 0.33.7
The reader knows the grammar approximately: that mv takes a status, not
whether it is a positional or --status, and that set has a flag per section,
not whether the criteria one is --acceptance or --criteria. In a shell fish
answers that as the line is typed. On the board there was nothing, and
getting it wrong cost a rejected line and a guess.

usage_of walks the typed verb against the clap definition and renders its
usage, so a flag added to a command is described here the day it is added.
A table of synopses kept beside it would be a second grammar, and it would
go stale silently: nothing but a reader typing that verb would ever see the
two disagree. The Usage: label is dropped, being the name of a block in a
help page of several where this is one line beside the line it describes.

It takes the keys' slot. esc and enter are two keys a reader learns once,
against a synopsis that is different for every verb; a refusal still wins
over both while it is up, being what was just said about the line that is
still on the row. refusal is the half that says what is wrong where this
says what would have been right.

A verb that resolves to nothing draws nothing and complains about nothing,
since the line is half typed most of the time the row is looked at. A
group's child is walked when the second word names one, so campaign set
describes set; while that word is half typed the group's own usage stands.

Grey, and cut with an ellipsis rather than wrapped: the footer is one row
and a second would reflow the columns every time a verb resolved. There is
always at least the keys' width to cut into, because that width comes off
the row before the line is windowed, so the usage never takes a cell from
what is being typed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-15 16:51:08 +02:00
28 changed files with 692 additions and 57 deletions
Generated
+1 -1
View File
@@ -1563,7 +1563,7 @@ dependencies = [
[[package]]
name = "worklane"
version = "0.33.6"
version = "0.33.12"
dependencies = [
"anyhow",
"assert_cmd",
+1 -1
View File
@@ -1,6 +1,6 @@
[package]
name = "worklane"
version = "0.33.6"
version = "0.33.12"
edition = "2024"
[dependencies]
+11 -2
View File
@@ -56,15 +56,24 @@ patch minor major: release
# A release rewrites the last commit, so refuse anything that would make that
# rewrite lose work or orphan a tag.
#
# Untracked character devices are not work: an agent sandbox bind-mounts /dev/null over
# protected paths such as .bashrc, and git cannot commit a device anyway. Untracked files
# are listed one by one, not with --directory, because the sandbox also mounts devices
# inside an untracked .claude/, and a collapsed directory entry is never a device.
release:
@set -e; \
if ! git rev-parse -q --verify HEAD >/dev/null 2>&1; then \
echo "error: no commits yet, so there is no commit to fold a version bump into. Commit first." >&2; \
exit 1; \
fi; \
if [ -n "$$(git status --porcelain)" ]; then \
dirty=$$( { git status --porcelain --untracked-files=no; \
git ls-files --others --exclude-standard | while IFS= read -r f; do \
[ -c "$$f" ] || echo "?? $$f"; \
done; } ); \
if [ -n "$$dirty" ]; then \
echo "error: working tree is dirty. Commit or stash first, and decide whether that work belongs in this version:" >&2; \
git status --short >&2; \
echo "$$dirty" >&2; \
exit 1; \
fi; \
if [ -n "$$(git tag --points-at HEAD)" ]; then \
+2
View File
@@ -1,3 +1,5 @@
<img src="logo/worklane-badge-256.png" width="96" alt="worklane logo">
# Worklane
Worklane is a local Kanban flow for agentic software development.
+75 -7
View File
@@ -1,6 +1,6 @@
---
name: worklane-review
description: Review a finished worklane ticket against the code that claims to close it, and record the verdict on the board. Use when asked to review a ticket, to check whether a ticket is really done, or to verify that an implementation matches its acceptance criteria, whether the ticket is named by id, by title or as "the one in reviewing". Covers finding the commits, judging each criterion against the code, and what a reviewer may and may not write back to the board.
description: Review a finished worklane ticket against the code that claims to close it, and record the verdict on the board. Use when asked to review a ticket, to check whether a ticket is really done, or to verify that an implementation matches its acceptance criteria, whether the ticket is named by id, by title or as "the one in reviewing". Covers finding the commits, judging each criterion against the code, what a reviewer may and may not write back to the board, and how to close a ticket whose work is already on master by filing its remaining issues as new tickets.
---
# Reviewing a worklane ticket
@@ -14,14 +14,21 @@ addressed and the argument traps, is the `worklane` skill; read that too.
## What a review produces
Three things, in this order, and nothing else:
Steps 1 to 3 are the same for every review. What you write back depends on one question
answered in step 2: **is the work already on the default branch** (master or main)?
**Not yet landed** (on a branch, or not merged): steps 4 and 5, which produce
1. **One comment** on the ticket, in the structure below.
2. **Unticked criteria**, for the ones the code does not actually meet.
3. **Appended criteria**, for work the review found that the ticket never asked for.
You do not tick a criterion, you do not move the ticket, and you do not fix the code.
Each of those has a reason, given where it comes up.
and nothing else. You do not tick a criterion, you do not move the ticket, and you do not
fix the code. Each of those has a reason, given where it comes up.
**Already landed**: skip steps 4 and 5 and follow step 6 instead. The findings become new
tickets rather than appended criteria, and the review ends with you moving the ticket to
done. You still never tick a criterion and never fix the code.
## 1. Read the ticket before the code
@@ -59,6 +66,16 @@ Widen it with the files the description names, since a ticket that names
`src/tui.rs` is reviewable through `git log -p -- src/tui.rs` even when no commit
message mentions it.
Once you have the commits, check whether each one is on the default branch. This decides
whether you go on to steps 4 and 5 or to step 6, so settle it now:
```
git merge-base --is-ancestor 6d327df master && echo landed # use main if the repo has no master
```
The work has landed only if **every** reviewed commit is on the default branch. If some
are and some are still on a branch, it has not landed: follow steps 4 and 5.
**If nothing names the ticket, that is the finding.** Do not review the working tree on
the assumption that whatever is uncommitted must be the work, and do not report a pass
you could not check. Comment what you searched for and stop: a ticket sitting in
@@ -87,17 +104,21 @@ Then the two questions the criteria cannot ask themselves:
- **What did this change break that no criterion covers?** Silent behaviour changes,
a message or exit code something else reads, an edge case the ticket never named.
- **What did the ticket never think of?** That is what you append in step 5.
- **What did the ticket never think of?** That is what you append in step 5, or file as a
ticket in step 6.
## 4. Write one comment
**If the work has landed, skip to step 6 now.** It uses this comment's structure, but only
after the new tickets exist, so their ids can go in it.
One call, one comment. Not one per criterion: the board renders comments in the order
they were written, and a review split over eight of them cannot be read as a verdict.
```
worklane comment 1b78a24 "**Verdict**: two criteria unmet, the scroll clamp is off by the header
**Work reviewed**: 4edc7fa, 6d327df on master
**Work reviewed**: 4edc7fa, 6d327df on feature/tui-scroll, not merged
**Criteria**
1. met - PageUp and PageDown reach detail_scroll, src/tui.rs:412
@@ -142,7 +163,54 @@ without making it clearer.
**Do not move the ticket.** `mv` belongs to whoever does the work, the same way ticking
does. Your half is the recommendation in the comment; acting on it is theirs. A reviewer
that reviews and closes in one breath leaves nobody to disagree with.
that reviews and closes in one breath leaves nobody to disagree with. This rule holds
for work that has not landed; landed work follows step 6.
## 6. When the work is already on master
Use this step instead of steps 4 and 5 when step 2 found every reviewed commit on the
default branch. Do not do steps 4 and 5 as well.
Landed work is not sent back to committed. That would reopen code that has shipped, and
whatever fixes the findings is a new change anyway. So every remaining issue moves to a
new ticket, and this ticket is closed.
An **issue** is any of these: a criterion you judged not met, a finding from the two
questions in step 3, and a "cannot tell" whose answer needs work, such as a missing test.
A "cannot tell" you settle by reading or running something is not an issue: settle it.
Do these in order, and do not skip ahead:
1. **File a ticket for every issue**, the way the `worklane` skill says, searching the
backlog first. Issues that are related, because they touch the same function or one
fix would close them all, go into one ticket together. Unrelated issues get a ticket
each. An issue that already has an open ticket gets a comment there, not a new one.
2. **Link each new ticket back** to the one under review:
`worklane relate <new> --relates-to 1b78a24`, or `worklane relate <new>
--regression-of 1b78a24` when the reviewed change broke something that used to work.
3. **Write the review comment**, in the structure of step 4. List each issue under
`**Findings**` with the id of the ticket that now holds it, and recommend done.
4. **Untick every unmet criterion** with `worklane uncheck`, as in step 5, so the closed
ticket does not claim what the code does not do. **Do not append criteria**: work for
a later commit belongs to the ticket that commit will close, and nobody works a done
ticket.
5. **Write a closing comment**, separate from the review comment, immediately before the
move. It says why the ticket is closing and names the ticket that holds each remaining
issue:
```
worklane comment 1b78a24 "Moving to done: the work is on master, and every remaining issue has its own ticket: 7bfb9fc (wrapped-line clamp), 4179958 (footer keys)"
```
With no issues at all, steps 1, 2 and 4 have nothing to do, and the closing comment
says that: `Moving to done: the work is on master and the review found no remaining
issues`. The review comment is the verdict; the closing comment is the reason for the
status change, and it sits in the history right above the move. Without it, a done
ticket with unticked criteria looks closed by mistake.
6. **Move it to done**: `worklane mv 1b78a24 --status done`. This is the only move a
reviewer makes. Make it last: an issue without a ticket is lost once this one is done.
With every issue in its own ticket, nothing is left here for the implementer, and
leaving the ticket in `reviewing` only hides that the review is finished.
## What a reviewer does not touch
+1 -1
View File
@@ -16,7 +16,7 @@ The documents and the opencode tool file the binary carries, and how they are in
- The refusal message names the document it is about, `install-skill worklane --print`, since with several installed "compare with --print" does not say compare what
- **A refused document does not stop the ones behind it.** The loop reports an outcome per document and the "pick it up on their next session" line is printed once, and only when something was actually written
- **A role skill is its own document, not a section of `SKILL.md`.** The frontmatter description is the whole of what decides whether a skill loads, and one description cannot name both "anything touching a ticket" and "only when a review is asked for" without fitting neither. It is also why the review document does not restate the CLI: it says to read the `worklane` skill too
- The review skill's own rules are guarded by `the_review_skill_keeps_the_decisions_that_define_it`, because each of them is a line an edit could drop without breaking anything: **the reviewer never ticks a criterion** (a tick is the implementer's claim, unticking is the review disagreeing, and one mark for both loses the disagreement), **never moves the ticket** (`mv` belongs to whoever does the work, the reviewer's half is the recommendation), and **never reviews the working tree when no commit names the ticket** (it says what it searched for and stops, since an untraceable ticket in `reviewing` is itself the finding)
- The review skill's own rules are guarded by `the_review_skill_keeps_the_decisions_that_define_it`, because each of them is a line an edit could drop without breaking anything: **the reviewer never ticks a criterion** (a tick is the implementer's claim, unticking is the review disagreeing, and one mark for both loses the disagreement), **never moves the ticket** (`mv` belongs to whoever does the work, the reviewer's half is the recommendation) **unless the work is already on master** (then each finding gets its own ticket, related ones sharing one, and the reviewer moves the original to done once all of them are filed, after a comment saying which ticket holds each remaining issue, since a done ticket with unticked criteria otherwise reads as closed by mistake: sending landed work back to committed reopens shipped code, and leaving it in reviewing with nothing left to do only hides that the review is over), and **never reviews the working tree when no commit names the ticket** (it says what it searched for and stops, since an untraceable ticket in `reviewing` is itself the finding)
- **The plan skill is the one that can do damage, so its rules are the ones under test.** `set --tags` replaces the whole field, so a sweep that restates a ticket's tags incompletely deletes the rest, and a due date is neither validated nor clearable. `the_plan_skill_keeps_the_rules_that_bound_a_sweep` pins propose-then-apply and those two traps, because a document that loses them still reads like a plan
- `.opencode/agent/feature-planner-agent.md` is **deliberately not folded into `PLAN.md`**. It decomposes a feature request into new tickets, which is intake; `PLAN.md` orders the tickets that already exist. Merging them would give one document two jobs and a frontmatter description that fits neither, which is the same reason the review skill is its own document
- **`install-tool` is a second command, not a flag on `install-skill`, because the two artifacts are not alike.** A skill is inert markdown that any agent can read and it reaches both from one path; the tool is executable TypeScript that reaches opencode alone. Claude Code has no directory it scans for a tool definition at all: `claude mcp add` with a `stdio`, `sse` or `http` transport is the only way a tool enters its tool list, and its plugin system adopts `agents`, `hooks`, `monitors`, `workflows`, `output-styles` and `themes` and nothing named tools. So an MCP server, a different artifact, would be what reached it. Verified against Claude Code 2.1.238
+2
View File
@@ -18,6 +18,8 @@ The generated half, the fish half, and what keeps the two honest.
- **A `ValueEnum` is never listed twice, and `argument_at` is why the fish half's two hand-written value lists are the only ones.** clap emits the possible values of an *option*, so `mv --status` and `set --clear` need nothing here and the board reads them off the same definition with `Arg::get_possible_values`. The `ls` status and the `completions` shell are positionals, which the fish generator emits nothing for, so those two are written into the block from the enums — and the board reaches them through `get_positionals`, which needs no `Command::build` the way `get_index` would
- **`RELATION_KIND_FLAGS` is the one position clap cannot answer for.** `relate --clear` takes a kind and then a target, two values of different kinds under one flag, so possible values on it would refuse every target. Both renderers therefore say so themselves: the fish rule lists `RelationKind::ALL` and the table names the pair
- **`ls --ids` is the machine-readable listing**, and one of the three outputs in the tree meant to be parsed: the short id, a tab, the title, unstyled. Two fields because fish reads what follows a tab as the description and a script reads `cut -f1`. It includes done, which the decorated listing leaves out, because a completion has to be able to name a finished ticket, and it skips a missing status directory rather than refusing, because an error printed over a shell prompt is worse than no candidates. The filters still apply, and an unknown `--campaign` is still refused
- **A flag is recognised by either spelling, `--status` and `-s` alike.** `long_name` translates the letter through the command that holds the flag, so every table above stays keyed on the long name and nothing here keeps a second list of the letters. The prompt read a flag by its two hyphens until then: `mv --status ` offered the five statuses and `mv -s ` offered nothing. **One letter, never a cluster** — `mv -fs done` would be the honest reading of the last letter, but `--title`, `--acceptance` and a comment body all take a leading hyphen on purpose, and a criterion typed as `-fixes the offset` must not be answered with statuses. `a_short_flag_answers_what_its_long_spelling_answers` walks every option with both spellings on every command and nested command, so an option given a letter tomorrow is covered the day it is given one
- **The fish rules name the letter too, `-s g -l tags`.** The same hole on the other half: `append -g <TAB>` offered nothing where `append --tags <TAB>` offered the board's tags, because the dynamic rules were rendered with `-l` alone. `fish_option` reads the letter off the definition per command, so a rule for an option with none is what it always was. Clap's own generated half already emitted both spellings, which is why only the dynamic rules were short
- **A flag's possible values are read off the command that *holds* the flag, nested or not.** `argument_at` resolves the group's child when the second word names one, so `campaign ls --state` reaches `ls`'s own arguments rather than `campaign`'s, which carry no such flag. Without that the prompt offered nothing where fish offered the three values, and the promise that a `ValueEnum` added anywhere is typeable on the board the day it is added held only for a top-level command
- **`campaign ls --ids` is the same flag and the same two fields for the other object**, and it deliberately skips the member counting the decorated listing does: `members()` reads every ticket on the board, and the caller here is a shell filling in candidates on a keypress. It also prints nothing on an empty board, where the decorated listing prints a sentence, because a sentence offered as a candidate is worse than no candidates
- **`worklane tags` is the third, and it is a command rather than a mode on `ls`.** Two reasons: `ls --tag <tag>` answers what carries a tag and cannot answer what tags exist, which is the question a grooming sweep starts from, and a `--tags` beside a `--tag` is one letter from a filter that means something else. Alphabetical and case sensitive, matching the filter, so `bug` and `Bug` list separately and land next to each other, which is where a near-duplicate is spotted. Every status, done included: a tag that has fallen out of use is still part of what the vocabulary has been. `assets/PLAN.md` used to tell the agent to count tags with a `show` per ticket, and now points here
+1
View File
@@ -11,6 +11,7 @@ The commit convention and the version bump that goes with it.
- Before every commit, decide whether the change warrants a version bump in `Cargo.toml`
- Always ask the user to confirm the bump and its kind before making it — never bump silently, and never skip the question because the answer looks obvious
- **`make patch`, `make minor` and `make major` do the mechanics**, run after the commit is in: each bumps `Cargo.toml` and the `worklane` entry in `Cargo.lock`, appends `, and bump to <version>` to the commit's subject, folds the bump into that commit, and tags it. Bumping by hand is how a version comes to be left untagged, which is what the one action is for. It refuses on a dirty tree, on an already-tagged `HEAD` and on a `HEAD` that is already pushed, since each of those makes the amend lose work, orphan a tag or need a force push
- **Untracked character devices do not make the tree dirty.** An agent sandbox bind-mounts `/dev/null` over protected paths such as `.bashrc`, `.gitconfig` and files inside `.claude/`, so git sees untracked entries that do not exist outside the sandbox, and `make patch` refused a clean tree. A device cannot be committed, so the check skips them. Untracked files are listed one by one rather than with `--directory`: the collapsed `.claude/` entry is a directory, not a device, and kept the refusal alive
- Pre-1.0, so: patch for fixes and internal changes, minor for a new command, flag or changed output, major only for a deliberate 1.0
- **Changed output means the CLI's output.** That is the surface scripts and agents read, so a changed listing, message or exit code is a minor. A change to what the board draws is a patch however visible it is, since nothing consumes the frame. See [The Board View](tui-board.md)
- **Settling output that shipped one version ago is a patch**, not a second minor. 0.15.1 changed the relation mark 0.15.0 had just introduced, and 0.15.2 added the status mark beside it: the minor was the arrival of a marked relations block, and settling what it marks belongs to that. Three minors in an hour would tell anyone reading the tags that there were three features
+5 -3
View File
@@ -20,7 +20,7 @@ The TUI: the columns, the cards, the frame, the pickers and the footer.
- **`wrapped_height` is the one measurement.** `last_offset` is it less the viewport and `page_indicator` takes the same two numbers, so the clamp and the indicator cannot disagree. A second `line_count` call, or a count of the raw lines, is a number free to drift, and an indicator that says there is more to read where the scroll refuses to move is worse than none
- **The furthest offset is the last page by definition, not by division.** The clamp stops at the wrapped height less the viewport, which is not a page boundary, so the final screenful is partial: `offset / step + 1` reads `pg 2/3` at the bottom of a 25 row ticket in a 10 row viewport and claims there is more below
- **The pages are counted in `scroll_step`, a screenful less the overlap line, not in whole screenfuls.** The step is what the keys take, so counting in it names only pages `pgdn` can land on. Counting by screenfuls puts a 30 row ticket in a 10 row viewport at `pg 3/3` two rows short of its end, since three presses are what it takes to get there
- The indicator is dropped whole on an overlay too narrow for it, the rule a corner and the tags row already follow, and absent entirely when nothing scrolls, the way an untagged card spends no row on tags
- The indicator is dropped whole on an overlay too narrow for it, the rule a corner follows, and absent entirely when nothing scrolls, the way an untagged card spends no row on tags
- `page_indicator` takes four numbers and returns an `Option<String>`, so every case above is pinned without a terminal. The drawn tests exist for the two things arithmetic cannot answer: which border it landed on and what colour it reached the screen in
- **Columns scroll to keep the selected card in view.** `Board::offsets` holds one offset per column, parallel to `columns` and resized in step by `reload`, so a column you leave stays where it was. The keypress aligns the focused column via `follow_selection(screen)`, taking the screen size for the same reason `scroll_detail` does: the visible height belongs to the terminal, which only the caller measures between draws
- Card heights are measured on `card_lines`, never assumed, on both the keypress and the draw side (`card_height`, and the `starts` vec as the cards are built). An alignment that trusted a fixed card height would drift from the renderer the first time the card changed shape
@@ -46,7 +46,7 @@ The TUI: the columns, the cards, the frame, the pickers and the footer.
- **The comment count is the same field discipline and the one entry on that pass that costs a directory listing.** The history lives outside the ticket file, so `count_comments` is a `read_dir` rather than a parse: `.md` only, the filter `read_history` applies, and no body is read, because a count needs none of them. **It counts comments and not entries**, off the kind in the filename, so a card still says how many things somebody said: a ticket that has moved three times has not been talked about, and counting the moves would put a number on every card on the board. `collect_ticket_items` derives the board from `status_path.parent()` instead of taking it as a second argument, so a status directory from one board cannot arrive with the history of another. `history_dir` spells the path once for the writer, the reader and the counter, the way `campaigns_dir` does. Zero draws nothing, not a `0` and not a blank: an uncommented card is the row it has always been, which `a_card_with_no_comments_spends_nothing_on_the_corner` pins to the exact spacing
- **The count is cyan and the mark is `COMMENT_MARK`, U+275E, a Dingbat.** It is the only coloured thing on a row whose owner and criteria count are grey, because two counts side by side otherwise read as one number in brackets and another that lost its brackets. Not U+1F4AC SPEECH BALLOON: emoji presentation and East Asian Width Wide, so it draws two cells where `spans_width` counts one character and every corner on the card lands a cell out. Not U+1F5E8 LEFT SPEECH BUBBLE either: text presentation and Neutral, but in a pictograph block most terminal fonts leave as tofu. Check both properties before swapping the glyph
- **`the_count_is_read_when_the_items_are_collected_and_not_per_draw` takes the history directory away after the board is built**, and is paired with `a_comment_added_after_the_board_was_built_reaches_the_card_on_reload`, because a count that never asks the filesystem again would pass the first test by never changing. The digest already moves when a comment lands, so the reload is what recounts
- **A card names its campaign on the label row, before the tags, in bold.** `labels_line` draws both, `CAMPAIGN_MARK` (`~`) for the campaign and `#` for a tag, and the campaign takes the row's width first: two cards in one campaign is what a reader looking for a campaign is looking for, and the tags are the context around it. So a row too narrow for both drops the tags whole and keeps the campaign, the order `corner_line` and `project_label` already follow, and a campaign the row will not hold at all goes whole too. A ticket in neither spends no row, so **a ticket in no campaign renders exactly as it did before campaigns reached the card**
- **A card names its campaign on the label row, before the tags, in bold.** `labels_line` draws both, `CAMPAIGN_MARK` (`~`) for the campaign and `#` for a tag, and the campaign takes the row's width first: two cards in one campaign is what a reader looking for a campaign is looking for, and the tags are the context around it. So a row too narrow for both gives up tags until the two fit and keeps the campaign, the order `corner_line` and `project_label` already follow, and a campaign the row will not hold at all goes whole too. A ticket in neither spends no row, so **a ticket in no campaign renders exactly as it did before campaigns reached the card**
- **`Card::campaign` is a resolved `Cell`, not a uuid**, settled at reload the way `project` and `blocked` are. `TicketItem::campaign` already carries the uuid off the pass that builds the card; the name is in another directory, so `columns_of` reads `CampaignIndex` once per project and hands it to every card. Never per draw, the rule `criteria` and `tags` already hold. The merge carries the resolved cell rather than looking it up again, for the reason it carries `blocked`: a campaign is addressed inside one `.worklane`, so a merged lookup could answer one project's uuid with another project's campaign
- **A campaign the board does not hold labels nothing**, the answer `mark_blocked` gives a dangling blocker. `campaign_cells` renders that case as `_missing_` because a metadata table is a place to report a dangling reference; a card is not
- **`c` opens the campaign picker, and taking a campaign filters the tab's columns to its members.** Not a fifth tab: a campaign groups across the flow, so the shape of the answer is the statuses with fewer cards in them, which is what `campaign show` already answers the question in. Every column is kept, empty ones included. The filter is applied in `reload`, where the columns are built, so nothing downstream has to ask whether a campaign is selected — the board simply holds fewer cards, and `first_match`, `column_count` and the copy key all keep working unchanged
@@ -100,7 +100,9 @@ The TUI: the columns, the cards, the frame, the pickers and the footer.
- **`Tab::standing` is gone with it.** The frame's standing is the row's, because two counts of one number are two numbers free to drift — the rule `wrapped_height` holds for the scroll. `the_standings_are_read_when_the_cards_are_and_not_per_draw` takes the status directories away after the board is built, paired with `a_member_finished_after_the_board_was_built_completes_its_campaign` for the reason the comment count's two tests are paired: a standing that never asked the filesystem again would pass the first by never changing
- **`q` takes off one layer at a time, in the order they were put on**: the overlay, then the campaign filter, then the board. `Board::dismiss` holds all three, and it takes the screen now because clearing the filter reloads and has to follow the selection. Selecting a campaign closes an open ticket, the answer hiding the done column already gives: the ticket may not be on the filtered board at all, and swapping it for a different one without saying so is how a person acts on the wrong ticket
- **`digest` watches the campaigns directory** as well as the statuses and the history. A campaign filed elsewhere has to reach the picker and a codename edited by hand has to reach every card that names it, and a directory's own mtime would miss the edit
- **The tags go under the title, dimmed, each prefixed with `#`.** The field was invisible on the board: nothing said a ticket was tagged `bug` without opening it. The marker is what stops the row reading as a third line of the title, since a tag is an ordinary word and the title sits directly above it. The row is dropped whole when the column will not hold it, the rule a corner follows, and an untagged ticket spends no row at all, the way a short title spends no second one
- **The tags go under the title, dimmed, each prefixed with `#`.** The field was invisible on the board: nothing said a ticket was tagged `bug` without opening it. The marker is what stops the row reading as a third line of the title, since a tag is an ordinary word and the title sits directly above it. An untagged ticket spends no row at all, the way a short title spends no second one
- **A row the column will not hold draws the tags that fit and ends in `(+n)`**, the count of the ones it left out. Whole tags only, the rule a corner follows: `bug` and `bugfix` cut to the same width say the same thing. What changed in 39be95b2 is the other half of that rule — the row used to go whole, so a narrow column, which is exactly where a reader is scanning cards for a tag, showed no tags at all. A short row is allowed as long as it says it is short, and the indicator is the entire difference between a cut list and one that reads as the ticket's whole list. So a row with no room for one tag beside the count is still dropped whole: `(+3)` alone tells nobody anything, and a tag drawn without the count would lie. `tags_that_fit` measures the indicator as part of the row it counts rather than reserving it up front, because `(+9)` and `(+10)` are different widths and a list of under ten should not pay for the tenth
- **The count is grey and parenthesised**, not a colour of its own and not bracketed: it is a fact about the row rather than another tag on it, and `[n/m]` two rows below is the criteria count
- `tags` is a field on `TicketItem`, filled in `collect_ticket_items` through `parse_tags`, for the reason the criteria count is. `parse_tags` splits the comma-separated field into whole trimmed values, so a caller asking for `bug` is not answered by `bugfix`, and reads absent, `_None_` and empty as the same answer
- **A held-up card carries `BLOCKED_MARK`, `×`, after its id, in brightred.** The constant lives in `util.rs` and the relations block draws the same one, since both say the same word. A ticket its blocker has not moved out of the way of looked exactly like one that is ready, and the board is where the next thing to pick up is chosen. The mark is `mv`'s own rule asked one column ahead, so it says this cannot advance rather than that a dependency was ever recorded: a card in committed whose blocker is in reviewing is unmarked, because reviewing is where it may go, and the same card is marked once it sits in reviewing and only done is left. The two terminal columns have no next stage and nothing in them is drawn blocked. Not a fourth circle from Geometric Shapes: those belong to the priority meter two cells away and would read as part of that ramp. The multiplication sign is Latin-1, like the middle dot the unset priority draws, so it renders wherever the meter does
- **The mark goes after the id, not before it.** Ahead of the id it would push every id in the column out of line whenever one card was blocked, which costs more than one card's state is worth. It is measured before the project label and the due date, so both give way to it: those are context for a ticket somebody can start, and this is the one thing on a card that says not to. Dropped whole when the row cannot hold the identity and the mark together, the rule a corner follows
+4
View File
@@ -33,6 +33,10 @@ The three input modes on the board and the key that copies an id off it.
- **The selection is restored by uuid across that reload, never by index.** `mv` puts the card in another column, `set --title` renames its file, and a filter can drop it out of view entirely, so the slot is not the ticket. `Board::reselect` has three answers: the card is in a drawn column and the selection goes to it; it is on the board but in a column the rotation is hiding, which is where `--status done` lands by default, so the notice says where it went and which key shows it; or the filter no longer holds it, which is said too, since a card vanishing from under the highlight reads as a bug in the board
- **The merge tab is refused, for now.** It is the one tab that is not a board — its cards came from several `.worklane` directories and it is none of them — so `Board::current_project` answers `None` there and the command is refused rather than landing on whichever project came first. Routing by the card a command names is ebc5755. The project is resolved by index and not by the tab's name, which is a label two projects can share: e1d79c3 is exactly that, and a write routed by name would be that bug with a file changing at the end of it
- **`Notice` holds as many lines as the command used, and `Board::notice_on_row` decides where they go.** One line with nothing else holding the row draws on the footer, where a copy's notice has always drawn. Anything else — several lines, or any answer at all while the prompt is still open on an error — draws as a box at the foot of the columns, cut to what the columns leave with the dropped count on its last row. A box rather than more rows of footer, and that is the whole reason it is an overlay: a footer that grew and shrank as notices came and went would reflow the columns on every keypress, moving every card the reader is looking at. `draw` and `draw_footer` both ask `notice_on_row`, so the two cannot come to disagree and draw the message twice or not at all
- **The command's own usage line takes the keys' slot as soon as the verb resolves.** The reader knows the grammar approximately — that `mv` takes a status, not whether it is a positional or a flag, and that `set` has a flag per section, not whether the criteria one is `--acceptance` or `--criteria` — which is what a shell answers as the line is typed and the board answered with nothing. `usage_of` walks the typed verb against the clap definition and renders *its* usage, so a flag added to a command is described here the day it is added; a table of synopses kept beside it would be a second grammar going stale silently, since nothing but a reader typing that verb would see the two disagree. The `Usage: ` label is dropped, being a block name in a help page of several where this is one line beside the line it describes
- **`esc` and `enter` are what the row gives up for it.** Two keys a reader learns once, against a synopsis that is different for every verb. A refusal still wins over both while it is up, being what was just said about the line that is still on the row, and `refusal` is the half that says what is *wrong* where this says what would have been right
- **A verb that resolves to nothing draws nothing, and complains about nothing.** The line is half typed most of the time the row is looked at, so an error about `com` is noise where a reader is still typing. A group's child is walked when the second word names one, so `campaign set` describes `set`; while that second word is half typed the group's own `campaign <COMMAND>` stands, which is what has been typed so far
- **Grey, and cut with an ellipsis rather than wrapped.** Grey is the chrome colour and says the same thing the suggestion's does: this is not in your line. The footer is one row, and a second one would reflow the columns every time a verb resolved — the reason a notice of several lines is a box. There is always at least the keys' width to cut into, because that width comes off the row before the line is windowed, so the usage never takes a cell from what is being typed
- **What a refused line shows is clap's own message with the usage block cut off**, which is also what drops the `--help` line after it. `--help` is the exception: it parses as an error of the kind that means *print this* and what it would print is a page, so it is caught and answered in a row's worth of words, or clap's help lands on the alternate screen the way an unsunk `println!` would. `--version` goes through the ordinary path, because what it prints is one line by construction. `ColorChoice::Never` on the command, so nothing that reaches the row carries an escape
- **The keys' width comes off the row before the line is windowed**, so a long command does not push them off the end; a message takes the row from the keys instead, since the reader has just been told something and `esc` and `enter` still do what they did. `prompt_window` anchors the window on the cursor's right edge, which costs the text *after* the cursor on a long line: keeping both ends needs a scroll offset in state, and the draw is where the width is known and the state is not writable
- `: command` is named in every footer state, because the key works in every one of them, and the prompt's own key is drawn as `↵ run`
BIN
View File
Binary file not shown.

After

Width:  |  Height:  |  Size: 15 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 18 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 38 KiB

+7
View File
@@ -0,0 +1,7 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 100 100" width="512" height="512"><title>worklane</title><defs><filter id="ink2" filterUnits="userSpaceOnUse" x="-5" y="-5" width="110" height="110" color-interpolation-filters="sRGB">
<feTurbulence type="fractalNoise" baseFrequency="0.045" numOctaves="2" seed="4" result="n"></feTurbulence>
<feDisplacementMap in="SourceGraphic" in2="n" scale="2.2" xChannelSelector="R" yChannelSelector="G" result="d"></feDisplacementMap>
<feTurbulence type="fractalNoise" baseFrequency="0.3" numOctaves="2" seed="11" result="g"></feTurbulence>
<feColorMatrix in="g" type="matrix" values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 -12 0 0 0 11.4" result="m"></feColorMatrix>
<feComposite in="d" in2="m" operator="in"></feComposite>
</filter></defs><rect width="100" height="100" fill="#e7e4df"/><g transform="translate(50 50) scale(.80) translate(-50 -50)"><g filter="url(#ink2)"><polygon points="19.27,5.61 25.36,4.44 31.42,5.74 37.75,5.74 44.02,4.81 49.80,4.66 56.74,4.26 61.80,5.80 67.94,5.01 74.65,4.42 81.88,4.67 85.78,10.09 89.96,14.23 95.59,18.18 94.18,26.06 95.24,30.67 94.54,37.80 95.27,43.04 95.38,50.37 94.26,57.04 94.86,62.76 95.41,67.79 94.82,74.12 94.61,80.76 89.73,86.12 84.77,89.77 80.20,95.51 74.52,94.92 68.64,94.25 62.27,95.71 56.50,94.22 49.30,94.27 44.47,95.34 38.15,94.52 32.06,95.40 24.49,95.21 18.90,94.51 14.67,91.02 9.31,86.56 4.10,81.11 5.29,75.51 5.03,69.37 5.46,61.86 4.74,56.40 4.99,50.59 4.38,44.20 5.77,38.13 4.47,31.36 4.49,25.65 5.13,18.75 8.86,13.63 15.22,10.42" style="fill:#2a2d31"></polygon><polygon points="22.54,11.28 28.29,11.25 34.39,11.67 40.70,11.63 47.25,11.82 53.11,11.90 58.87,11.75 65.73,11.65 71.73,11.54 77.53,11.81 83.13,16.71 88.43,22.55 88.24,28.77 88.08,34.77 88.60,40.56 88.32,47.12 88.21,52.89 88.69,59.35 88.84,65.49 88.68,71.16 88.92,77.51 83.33,83.13 77.92,88.63 71.25,88.32 64.85,88.66 59.07,88.51 53.20,88.17 47.02,88.45 40.74,88.37 34.63,88.84 28.18,88.53 22.61,88.41 16.94,82.81 11.64,77.95 11.95,71.18 11.13,65.67 11.61,59.17 11.07,53.50 11.56,46.52 11.61,40.73 11.32,34.41 11.10,28.26 11.18,22.91 16.59,16.55" style="fill:#e2652a"></polygon><polygon points="24.30,13.55 30.27,13.76 36.95,14.35 43.93,13.57 50.14,14.13 56.48,14.12 62.85,14.40 69.09,14.20 76.33,14.04 81.13,19.08 85.83,23.88 85.83,30.92 85.97,37.15 85.86,43.24 85.67,50.37 85.60,56.08 86.19,63.28 86.17,69.73 86.11,76.20 81.25,81.26 75.93,85.95 69.07,85.68 62.95,86.27 56.21,85.98 49.61,85.85 43.32,85.80 37.12,85.74 30.94,86.29 24.21,85.61 18.80,80.96 14.17,75.87 13.62,69.74 14.38,63.35 13.83,56.72 13.78,50.44 14.02,43.84 13.68,36.86 14.18,30.69 14.39,24.23 19.02,19.43" style="fill:#2a2d31"></polygon><polygon points="24.08,23.77 31.08,24.03 38.23,24.17 38.23,27.12 30.88,27.03 24.18,27.06" style="fill:#e2652a"></polygon><polygon points="23.84,30.87 31.24,30.62 38.01,30.99 37.92,39.37 31.33,39.31 23.86,39.30" style="fill:#e2652a"></polygon><polygon points="24.03,41.55 30.74,42.45 37.81,42.38 38.20,50.29 30.70,49.89 24.43,50.23" style="fill:#e2652a"></polygon><polygon points="23.89,52.84 31.16,53.17 37.83,52.59 38.17,61.43 31.17,60.66 24.08,60.80" style="fill:#e2652a"></polygon><polygon points="23.66,63.69 31.12,63.85 38.10,64.10 37.61,72.29 30.71,71.76 24.21,72.38" style="fill:#e2652a"></polygon><polygon points="43.00,24.22 50.03,24.04 56.89,23.88 57.10,26.76 49.81,26.78 42.99,26.79" style="fill:#e2652a"></polygon><polygon points="43.35,31.42 49.64,30.62 57.38,30.88 57.38,39.40 50.19,39.04 43.10,39.36" style="fill:#e2652a"></polygon><polygon points="43.37,41.55 50.04,42.35 56.87,41.85 57.26,49.74 50.39,49.64 43.23,50.37" style="fill:#e2652a"></polygon><polygon points="61.85,23.90 69.23,23.93 76.04,23.89 76.02,27.11 68.97,26.99 62.24,26.87" style="fill:#e2652a"></polygon><polygon points="62.25,31.01 69.42,30.82 76.29,30.86 76.11,39.36 68.73,38.57 62.28,38.78" style="fill:#e2652a"></polygon><polygon points="58.36,53.51 64.71,51.72 71.63,50.33 73.77,58.34 66.61,59.55 59.97,61.15" style="fill:#e2652a"></polygon><polygon points="25.09,32.53 26.05,31.80 25.57,31.65" style="fill:#2a2d31"></polygon><polygon points="27.23,32.53 28.25,32.00 27.54,31.65" style="fill:#2a2d31"></polygon><polygon points="29.36,32.53 30.45,31.82 30.02,31.65" style="fill:#2a2d31"></polygon><polygon points="31.48,32.53 32.65,32.01 32.14,31.65" style="fill:#2a2d31"></polygon><polygon points="33.68,32.53 34.85,31.84 34.43,31.65" style="fill:#2a2d31"></polygon><polygon points="26.06,34.51 27.15,33.78 26.55,33.63" style="fill:#2a2d31"></polygon><polygon points="28.44,34.51 29.35,34.07 28.74,33.63" style="fill:#2a2d31"></polygon><polygon points="30.39,34.51 31.55,34.13 30.97,33.63" style="fill:#2a2d31"></polygon><polygon points="32.53,34.51 33.75,34.08 33.20,33.63" style="fill:#2a2d31"></polygon><polygon points="34.68,34.51 35.95,33.89 35.29,33.63" style="fill:#2a2d31"></polygon><polygon points="24.92,36.49 26.05,35.80 25.31,35.61" style="fill:#2a2d31"></polygon><polygon points="27.08,36.49 28.25,36.03 27.55,35.61" style="fill:#2a2d31"></polygon><polygon points="29.23,36.49 30.45,35.80 29.92,35.61" style="fill:#2a2d31"></polygon><polygon points="31.58,36.49 32.65,35.87 32.09,35.61" style="fill:#2a2d31"></polygon><polygon points="33.88,36.49 34.85,35.98 34.31,35.61" style="fill:#2a2d31"></polygon></g></g></svg>

After

Width:  |  Height:  |  Size: 5.2 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 97 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 10 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 828 B

Binary file not shown.

After

Width:  |  Height:  |  Size: 21 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 2.0 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 3.2 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 45 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 4.6 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 46 KiB

+7
View File
@@ -0,0 +1,7 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 100 100" width="512" height="512"><title>worklane</title><defs><filter id="ink" filterUnits="userSpaceOnUse" x="-5" y="-5" width="110" height="110" color-interpolation-filters="sRGB">
<feTurbulence type="fractalNoise" baseFrequency="0.045" numOctaves="2" seed="4" result="n"></feTurbulence>
<feDisplacementMap in="SourceGraphic" in2="n" scale="2.2" xChannelSelector="R" yChannelSelector="G" result="d"></feDisplacementMap>
<feTurbulence type="fractalNoise" baseFrequency="0.3" numOctaves="2" seed="11" result="g"></feTurbulence>
<feColorMatrix in="g" type="matrix" values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 -12 0 0 0 11.4" result="m"></feColorMatrix>
<feComposite in="d" in2="m" operator="in"></feComposite>
</filter></defs><rect width="100" height="100" fill="#e7e4df"/><g filter="url(#ink)"><polygon points="19.27,5.61 25.36,4.44 31.42,5.74 37.75,5.74 44.02,4.81 49.80,4.66 56.74,4.26 61.80,5.80 67.94,5.01 74.65,4.42 81.88,4.67 85.78,10.09 89.96,14.23 95.59,18.18 94.18,26.06 95.24,30.67 94.54,37.80 95.27,43.04 95.38,50.37 94.26,57.04 94.86,62.76 95.41,67.79 94.82,74.12 94.61,80.76 89.73,86.12 84.77,89.77 80.20,95.51 74.52,94.92 68.64,94.25 62.27,95.71 56.50,94.22 49.30,94.27 44.47,95.34 38.15,94.52 32.06,95.40 24.49,95.21 18.90,94.51 14.67,91.02 9.31,86.56 4.10,81.11 5.29,75.51 5.03,69.37 5.46,61.86 4.74,56.40 4.99,50.59 4.38,44.20 5.77,38.13 4.47,31.36 4.49,25.65 5.13,18.75 8.86,13.63 15.22,10.42" style="fill:#2a2d31"></polygon><polygon points="22.54,11.28 28.29,11.25 34.39,11.67 40.70,11.63 47.25,11.82 53.11,11.90 58.87,11.75 65.73,11.65 71.73,11.54 77.53,11.81 83.13,16.71 88.43,22.55 88.24,28.77 88.08,34.77 88.60,40.56 88.32,47.12 88.21,52.89 88.69,59.35 88.84,65.49 88.68,71.16 88.92,77.51 83.33,83.13 77.92,88.63 71.25,88.32 64.85,88.66 59.07,88.51 53.20,88.17 47.02,88.45 40.74,88.37 34.63,88.84 28.18,88.53 22.61,88.41 16.94,82.81 11.64,77.95 11.95,71.18 11.13,65.67 11.61,59.17 11.07,53.50 11.56,46.52 11.61,40.73 11.32,34.41 11.10,28.26 11.18,22.91 16.59,16.55" style="fill:#e2652a"></polygon><polygon points="24.30,13.55 30.27,13.76 36.95,14.35 43.93,13.57 50.14,14.13 56.48,14.12 62.85,14.40 69.09,14.20 76.33,14.04 81.13,19.08 85.83,23.88 85.83,30.92 85.97,37.15 85.86,43.24 85.67,50.37 85.60,56.08 86.19,63.28 86.17,69.73 86.11,76.20 81.25,81.26 75.93,85.95 69.07,85.68 62.95,86.27 56.21,85.98 49.61,85.85 43.32,85.80 37.12,85.74 30.94,86.29 24.21,85.61 18.80,80.96 14.17,75.87 13.62,69.74 14.38,63.35 13.83,56.72 13.78,50.44 14.02,43.84 13.68,36.86 14.18,30.69 14.39,24.23 19.02,19.43" style="fill:#2a2d31"></polygon><polygon points="24.08,23.77 31.08,24.03 38.23,24.17 38.23,27.12 30.88,27.03 24.18,27.06" style="fill:#e2652a"></polygon><polygon points="23.84,30.87 31.24,30.62 38.01,30.99 37.92,39.37 31.33,39.31 23.86,39.30" style="fill:#e2652a"></polygon><polygon points="24.03,41.55 30.74,42.45 37.81,42.38 38.20,50.29 30.70,49.89 24.43,50.23" style="fill:#e2652a"></polygon><polygon points="23.89,52.84 31.16,53.17 37.83,52.59 38.17,61.43 31.17,60.66 24.08,60.80" style="fill:#e2652a"></polygon><polygon points="23.66,63.69 31.12,63.85 38.10,64.10 37.61,72.29 30.71,71.76 24.21,72.38" style="fill:#e2652a"></polygon><polygon points="43.00,24.22 50.03,24.04 56.89,23.88 57.10,26.76 49.81,26.78 42.99,26.79" style="fill:#e2652a"></polygon><polygon points="43.35,31.42 49.64,30.62 57.38,30.88 57.38,39.40 50.19,39.04 43.10,39.36" style="fill:#e2652a"></polygon><polygon points="43.37,41.55 50.04,42.35 56.87,41.85 57.26,49.74 50.39,49.64 43.23,50.37" style="fill:#e2652a"></polygon><polygon points="61.85,23.90 69.23,23.93 76.04,23.89 76.02,27.11 68.97,26.99 62.24,26.87" style="fill:#e2652a"></polygon><polygon points="62.25,31.01 69.42,30.82 76.29,30.86 76.11,39.36 68.73,38.57 62.28,38.78" style="fill:#e2652a"></polygon><polygon points="58.36,53.51 64.71,51.72 71.63,50.33 73.77,58.34 66.61,59.55 59.97,61.15" style="fill:#e2652a"></polygon><polygon points="25.09,32.53 26.05,31.80 25.57,31.65" style="fill:#2a2d31"></polygon><polygon points="27.23,32.53 28.25,32.00 27.54,31.65" style="fill:#2a2d31"></polygon><polygon points="29.36,32.53 30.45,31.82 30.02,31.65" style="fill:#2a2d31"></polygon><polygon points="31.48,32.53 32.65,32.01 32.14,31.65" style="fill:#2a2d31"></polygon><polygon points="33.68,32.53 34.85,31.84 34.43,31.65" style="fill:#2a2d31"></polygon><polygon points="26.06,34.51 27.15,33.78 26.55,33.63" style="fill:#2a2d31"></polygon><polygon points="28.44,34.51 29.35,34.07 28.74,33.63" style="fill:#2a2d31"></polygon><polygon points="30.39,34.51 31.55,34.13 30.97,33.63" style="fill:#2a2d31"></polygon><polygon points="32.53,34.51 33.75,34.08 33.20,33.63" style="fill:#2a2d31"></polygon><polygon points="34.68,34.51 35.95,33.89 35.29,33.63" style="fill:#2a2d31"></polygon><polygon points="24.92,36.49 26.05,35.80 25.31,35.61" style="fill:#2a2d31"></polygon><polygon points="27.08,36.49 28.25,36.03 27.55,35.61" style="fill:#2a2d31"></polygon><polygon points="29.23,36.49 30.45,35.80 29.92,35.61" style="fill:#2a2d31"></polygon><polygon points="31.58,36.49 32.65,35.87 32.09,35.61" style="fill:#2a2d31"></polygon><polygon points="33.88,36.49 34.85,35.98 34.31,35.61" style="fill:#2a2d31"></polygon></g></svg>

After

Width:  |  Height:  |  Size: 5.1 KiB

+7
View File
@@ -0,0 +1,7 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 100 100" width="512" height="512"><title>worklane</title><defs><filter id="ink" filterUnits="userSpaceOnUse" x="-5" y="-5" width="110" height="110" color-interpolation-filters="sRGB">
<feTurbulence type="fractalNoise" baseFrequency="0.045" numOctaves="2" seed="4" result="n"></feTurbulence>
<feDisplacementMap in="SourceGraphic" in2="n" scale="2.2" xChannelSelector="R" yChannelSelector="G" result="d"></feDisplacementMap>
<feTurbulence type="fractalNoise" baseFrequency="0.3" numOctaves="2" seed="11" result="g"></feTurbulence>
<feColorMatrix in="g" type="matrix" values="0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 -12 0 0 0 11.4" result="m"></feColorMatrix>
<feComposite in="d" in2="m" operator="in"></feComposite>
</filter></defs><g filter="url(#ink)"><polygon points="19.27,5.61 25.36,4.44 31.42,5.74 37.75,5.74 44.02,4.81 49.80,4.66 56.74,4.26 61.80,5.80 67.94,5.01 74.65,4.42 81.88,4.67 85.78,10.09 89.96,14.23 95.59,18.18 94.18,26.06 95.24,30.67 94.54,37.80 95.27,43.04 95.38,50.37 94.26,57.04 94.86,62.76 95.41,67.79 94.82,74.12 94.61,80.76 89.73,86.12 84.77,89.77 80.20,95.51 74.52,94.92 68.64,94.25 62.27,95.71 56.50,94.22 49.30,94.27 44.47,95.34 38.15,94.52 32.06,95.40 24.49,95.21 18.90,94.51 14.67,91.02 9.31,86.56 4.10,81.11 5.29,75.51 5.03,69.37 5.46,61.86 4.74,56.40 4.99,50.59 4.38,44.20 5.77,38.13 4.47,31.36 4.49,25.65 5.13,18.75 8.86,13.63 15.22,10.42" style="fill:#2a2d31"></polygon><polygon points="22.54,11.28 28.29,11.25 34.39,11.67 40.70,11.63 47.25,11.82 53.11,11.90 58.87,11.75 65.73,11.65 71.73,11.54 77.53,11.81 83.13,16.71 88.43,22.55 88.24,28.77 88.08,34.77 88.60,40.56 88.32,47.12 88.21,52.89 88.69,59.35 88.84,65.49 88.68,71.16 88.92,77.51 83.33,83.13 77.92,88.63 71.25,88.32 64.85,88.66 59.07,88.51 53.20,88.17 47.02,88.45 40.74,88.37 34.63,88.84 28.18,88.53 22.61,88.41 16.94,82.81 11.64,77.95 11.95,71.18 11.13,65.67 11.61,59.17 11.07,53.50 11.56,46.52 11.61,40.73 11.32,34.41 11.10,28.26 11.18,22.91 16.59,16.55" style="fill:#e2652a"></polygon><polygon points="24.30,13.55 30.27,13.76 36.95,14.35 43.93,13.57 50.14,14.13 56.48,14.12 62.85,14.40 69.09,14.20 76.33,14.04 81.13,19.08 85.83,23.88 85.83,30.92 85.97,37.15 85.86,43.24 85.67,50.37 85.60,56.08 86.19,63.28 86.17,69.73 86.11,76.20 81.25,81.26 75.93,85.95 69.07,85.68 62.95,86.27 56.21,85.98 49.61,85.85 43.32,85.80 37.12,85.74 30.94,86.29 24.21,85.61 18.80,80.96 14.17,75.87 13.62,69.74 14.38,63.35 13.83,56.72 13.78,50.44 14.02,43.84 13.68,36.86 14.18,30.69 14.39,24.23 19.02,19.43" style="fill:#2a2d31"></polygon><polygon points="24.08,23.77 31.08,24.03 38.23,24.17 38.23,27.12 30.88,27.03 24.18,27.06" style="fill:#e2652a"></polygon><polygon points="23.84,30.87 31.24,30.62 38.01,30.99 37.92,39.37 31.33,39.31 23.86,39.30" style="fill:#e2652a"></polygon><polygon points="24.03,41.55 30.74,42.45 37.81,42.38 38.20,50.29 30.70,49.89 24.43,50.23" style="fill:#e2652a"></polygon><polygon points="23.89,52.84 31.16,53.17 37.83,52.59 38.17,61.43 31.17,60.66 24.08,60.80" style="fill:#e2652a"></polygon><polygon points="23.66,63.69 31.12,63.85 38.10,64.10 37.61,72.29 30.71,71.76 24.21,72.38" style="fill:#e2652a"></polygon><polygon points="43.00,24.22 50.03,24.04 56.89,23.88 57.10,26.76 49.81,26.78 42.99,26.79" style="fill:#e2652a"></polygon><polygon points="43.35,31.42 49.64,30.62 57.38,30.88 57.38,39.40 50.19,39.04 43.10,39.36" style="fill:#e2652a"></polygon><polygon points="43.37,41.55 50.04,42.35 56.87,41.85 57.26,49.74 50.39,49.64 43.23,50.37" style="fill:#e2652a"></polygon><polygon points="61.85,23.90 69.23,23.93 76.04,23.89 76.02,27.11 68.97,26.99 62.24,26.87" style="fill:#e2652a"></polygon><polygon points="62.25,31.01 69.42,30.82 76.29,30.86 76.11,39.36 68.73,38.57 62.28,38.78" style="fill:#e2652a"></polygon><polygon points="58.36,53.51 64.71,51.72 71.63,50.33 73.77,58.34 66.61,59.55 59.97,61.15" style="fill:#e2652a"></polygon><polygon points="25.09,32.53 26.05,31.80 25.57,31.65" style="fill:#2a2d31"></polygon><polygon points="27.23,32.53 28.25,32.00 27.54,31.65" style="fill:#2a2d31"></polygon><polygon points="29.36,32.53 30.45,31.82 30.02,31.65" style="fill:#2a2d31"></polygon><polygon points="31.48,32.53 32.65,32.01 32.14,31.65" style="fill:#2a2d31"></polygon><polygon points="33.68,32.53 34.85,31.84 34.43,31.65" style="fill:#2a2d31"></polygon><polygon points="26.06,34.51 27.15,33.78 26.55,33.63" style="fill:#2a2d31"></polygon><polygon points="28.44,34.51 29.35,34.07 28.74,33.63" style="fill:#2a2d31"></polygon><polygon points="30.39,34.51 31.55,34.13 30.97,33.63" style="fill:#2a2d31"></polygon><polygon points="32.53,34.51 33.75,34.08 33.20,33.63" style="fill:#2a2d31"></polygon><polygon points="34.68,34.51 35.95,33.89 35.29,33.63" style="fill:#2a2d31"></polygon><polygon points="24.92,36.49 26.05,35.80 25.31,35.61" style="fill:#2a2d31"></polygon><polygon points="27.08,36.49 28.25,36.03 27.55,35.61" style="fill:#2a2d31"></polygon><polygon points="29.23,36.49 30.45,35.80 29.92,35.61" style="fill:#2a2d31"></polygon><polygon points="31.58,36.49 32.65,35.87 32.09,35.61" style="fill:#2a2d31"></polygon><polygon points="33.88,36.49 34.85,35.98 34.31,35.61" style="fill:#2a2d31"></polygon></g></svg>

After

Width:  |  Height:  |  Size: 5.1 KiB

+148 -8
View File
@@ -111,6 +111,36 @@ pub const TAG_NESTED_COMMANDS: [(&str, &str); 1] = [("tags", "set")];
/// every target.
pub const RELATION_KIND_FLAGS: [(&str, &str); 1] = [("relate", "clear")];
/// The long name of the flag a typed word spells, or nothing where it is not a flag.
///
/// `--status` is its own name and `-s` is clap's to translate, off the command that holds
/// the flag: a table of the shorts kept here would be a second list of every option the
/// tool has, and it would go wrong the first time one was given a letter.
///
/// **One letter, never a cluster.** `mv -fs done` is force and status and it is `status`
/// that takes the word after it, so the last letter of a cluster would be the honest
/// answer — but `--title`, `--description`, `--acceptance`, `--plan` and a comment body all
/// take a leading hyphen on purpose, and reading `-fixes the offset` as a cluster would
/// offer statuses inside a criterion. A clustered short is rare on a board where the line
/// is typed a word at a time; a hyphen-leading prose value is a documented feature.
fn long_name(arg: &str, holder: Option<&clap::Command>) -> Option<String> {
if let Some(long) = arg.strip_prefix("--") {
return (!long.is_empty()).then(|| long.to_string());
}
let mut letters = arg.strip_prefix('-')?.chars();
let short = match (letters.next(), letters.next()) {
(Some(letter), None) => letter,
_ => return None,
};
holder?
.get_arguments()
.find(|option| option.get_short() == Some(short))
.and_then(|option| option.get_long())
.map(str::to_string)
}
/// What an argument of a typed line names, where worklane can answer what goes there.
///
/// The board's command prompt completes against this: the tables above say *what* the
@@ -178,8 +208,10 @@ pub fn argument_at(args: &[String], index: usize) -> Option<Argument> {
.or(group);
// A flag's value is the argument after it, which is where the flag sits whether the
// value is half typed or has not been started.
if let Some(flag) = args.get(index - 1).and_then(|arg| arg.strip_prefix("--")) {
// value is half typed or has not been started. Spelled long or short: `-s` is the same
// flag as `--status` and the row has to answer both, which is what `long_name` is for.
if let Some(flag) = args.get(index - 1).and_then(|arg| long_name(arg, holder)) {
let flag = flag.as_str();
if TICKET_FLAGS.contains(&(verb, flag)) {
return Some(Argument::Ticket);
}
@@ -281,8 +313,9 @@ fn fish_dynamic() -> String {
let ticket_flags = TICKET_FLAGS
.iter()
.map(|(command, flag)| {
let option = fish_option(command, flag);
format!(
"complete -c worklane -n '__worklane_command_is {command}' -l {flag} \\\n \
"complete -c worklane -n '__worklane_command_is {command}' {option} \\\n \
-x -a '(worklane ls --ids)'"
)
})
@@ -299,12 +332,13 @@ fn fish_dynamic() -> String {
.map(|(parent, child)| format!("__worklane_nested_arg_of {parent} {child}"))
.collect::<Vec<_>>()
.join("; or ");
let campaign_flags = flag_list(&CAMPAIGN_FLAGS);
let campaign_flags = flag_list("ls", &CAMPAIGN_FLAGS);
let tag_flags = TAG_FLAGS
.iter()
.map(|(command, flag)| {
let option = fish_option(command, flag);
format!(
"complete -c worklane -n '__worklane_command_is {command}' -l {flag} \\\n \
"complete -c worklane -n '__worklane_command_is {command}' {option} \\\n \
-x -a '(worklane tags | cut -f1,3)'"
)
})
@@ -442,15 +476,40 @@ complete -c worklane -n '__worklane_first_arg_of install-skill' -a '{skills}' -d
)
}
/// Option names as fish wants them on a `complete` line, `-l one -l two`.
fn flag_list(flags: &[&str]) -> String {
/// Option names as fish wants them on a `complete` line, `-s o -l one -l two`, for the
/// options of one command.
fn flag_list(command: &str, flags: &[&str]) -> String {
flags
.iter()
.map(|flag| format!("-l {flag}"))
.map(|flag| fish_option(command, flag))
.collect::<Vec<_>>()
.join(" ")
}
/// One option as fish names it: its long name, and its letter where clap gave it one.
///
/// `-s g -l tags` rather than `-l tags` alone, or `append -g <TAB>` offers nothing where
/// `append --tags <TAB>` offers the board's tags — the same hole the board's own prompt had
/// until `long_name`, and the reason one table answers both halves is that neither may
/// answer a spelling the other does not. The letter is read off the definition and never
/// written here, so an option given one tomorrow is offered under it the day it is given.
fn fish_option(command: &str, flag: &str) -> String {
let cli = crate::command::Cli::command();
let short = cli
.find_subcommand(command)
.and_then(|command| {
command
.get_arguments()
.find(|option| option.get_long() == Some(flag))
})
.and_then(|option| option.get_short());
match short {
Some(letter) => format!("-s {letter} -l {flag}"),
None => format!("-l {flag}"),
}
}
/// The names a `ValueEnum` accepts, for a fish `-a` list.
///
/// Read off the enum rather than written out, so a status or a shell added to either one
@@ -774,6 +833,87 @@ mod tests {
assert!(shells.contains(&"fish".to_string()), "{shells:?}");
}
/// The fish half names an option by its letter too, wherever clap gave it one, so a
/// dynamic rule answers both spellings the way the prompt does.
#[test]
fn a_fish_rule_names_the_option_by_its_letter_as_well() {
let script = fish_dynamic();
// `append --tags` is the one flag in these tables with a letter, and it is the
// whole reason the rule is rendered rather than written: `-g` offered nothing.
assert!(
script.contains("-s g -l tags"),
"the tags rule does not name its letter:\n{script}"
);
// And one without stays as it was, rather than gaining an empty `-s`.
assert!(script.contains("-l campaign"), "{script}");
assert!(!script.contains("-s "), "an option with no letter got one:\n{script}");
// Read off the definition, never written here.
assert_eq!(fish_option("append", "tags"), "-s g -l tags");
assert_eq!(fish_option("ls", "tag"), "-l tag");
assert_eq!(fish_option("ls", "nosuchflag"), "-l nosuchflag");
}
/// A flag spelled short answers exactly what the same flag spelled long answers, on
/// every command and every option that has both.
///
/// Walked off the clap definition rather than listed, so an option given a letter
/// tomorrow is covered the day it is given one. `-s` was the report: `mv --status `
/// offered the five statuses and `mv -s ` offered nothing, because the row read a flag
/// by its two hyphens. A boolean's two spellings agree as well, both answering nothing,
/// which is the same statement about a value that is not there.
#[test]
fn a_short_flag_answers_what_its_long_spelling_answers() {
let cli = crate::command::Cli::command();
let mut seen = 0;
for command in cli.get_subcommands() {
let children: Vec<(String, &clap::Command)> = command
.get_subcommands()
.map(|child| (format!("{} {}", command.get_name(), child.get_name()), child))
.collect();
for (line, holder) in
std::iter::once((command.get_name().to_string(), command)).chain(children)
{
for option in holder.get_arguments() {
let (Some(short), Some(long)) = (option.get_short(), option.get_long()) else {
continue;
};
seen += 1;
assert_eq!(
at_cursor(&format!("{line} -{short} ")),
at_cursor(&format!("{line} --{long} ")),
"`-{short}` and `--{long}` answer differently on `{line}`"
);
}
}
}
assert!(seen > 20, "only {seen} options had both spellings, which is too few");
}
/// The two the report named, spelled out, so the walk above cannot pass by finding
/// nothing on either spelling.
#[test]
fn a_short_flag_reaches_the_values_and_the_board() {
let listed: Vec<String> = Status::ALL.iter().map(|s| s.as_str().to_string()).collect();
assert_eq!(values("mv -s "), Some(listed), "`-s` offers no statuses");
assert_eq!(values("mv -s bac"), values("mv --status bac"), "half typed");
// A tag, which comes off the board rather than out of the enum.
assert_eq!(at_cursor("append -g "), Some(Argument::Tag { declared: false }));
// And a cluster is deliberately not read, because `--title`, `--acceptance` and a
// comment body all take a leading hyphen: a value spelled `-fixes the offset` must
// not be read as `-s` and answered with statuses.
assert_eq!(at_cursor("mv -fs "), None);
assert_eq!(at_cursor("comment 1b78a24 -fs "), None);
}
/// The flag on a nested command is answered the same way, from the enum: nothing here
/// knows what a campaign's states are, and the values reach the prompt and fish alike
/// the day a fourth one is added to `CampaignState`.
+3
View File
@@ -526,6 +526,9 @@ mod tests {
"nothing names the ticket", // and the no-work-found case is answered
"Never tick a criterion",
"Do not move the ticket",
"already on master", // landed work: findings become tickets, then done
"File a ticket for every issue",
"Write a closing comment", // and says so before the move
"worklane uncheck",
"worklane append",
"cannot tell",
+417 -34
View File
@@ -980,12 +980,57 @@ fn command_name(matches: &clap::ArgMatches) -> Option<String> {
})
}
/// The usage line clap renders for the command the typed line names, or nothing while the
/// verb names none.
///
/// **Clap's own rendering, off the definition the parse uses**, so a flag added to a
/// command is described here the day it is added. A table of synopses kept beside it would
/// be a second grammar, and it would go stale silently: nothing but a reader typing that
/// verb would ever see the two disagree.
///
/// A verb that resolves to nothing answers `None`. The line is half typed most of the time
/// it is looked at, and a complaint about `com` is noise on a row the reader is typing on;
/// `refusal` is where a line that was actually entered is answered.
///
/// A group's child is walked when the second word names one, so `campaign set` describes
/// `set` and not `campaign`. While that second word is still half typed the group's own
/// usage stands, which is the honest answer: `campaign <COMMAND>` is what has been typed
/// so far.
///
/// The `Usage: ` label is dropped and the rest is kept verbatim. The label names the block
/// in a help page of several; this row is one line beside the line it describes, and the
/// cells are worth more than the word.
fn usage_of(args: &[String]) -> Option<String> {
// Colour off for the same reason the parse turns it off: what this row draws is a
// ratatui span, and an escape inside one is printed rather than obeyed.
let cli = <Cli as clap::CommandFactory>::command().color(clap::ColorChoice::Never);
let command = cli.find_subcommand(args.first()?)?;
// The child by exact name, which is what clap will resolve too. A half-typed one
// matches nothing and leaves the group's usage on the row.
let command = match args.get(1).and_then(|word| command.find_subcommand(word)) {
Some(child) => child,
None => command,
};
let usage = command.clone().render_usage().to_string();
Some(
usage
.strip_prefix("Usage: ")
.unwrap_or(&usage)
.trim()
.to_string(),
)
}
/// The one line the row carries for a line clap would not take.
///
/// Clap's own message, because the grammar is clap's: a complaint written here would
/// describe a rule this file does not own. What is dropped is the usage block and the
/// `--help` line after it, which are a paragraph — the synopsis is d7e493e's, and until
/// then the row says what is wrong rather than what would have been right.
/// `--help` line after it, which are a paragraph: this row says what is wrong, and
/// `usage_of` is what says what would have been right, on the same row for as long as the
/// verb resolves. A refusal wins the slot while it is up, being what was just said about
/// the line that is still there.
///
/// `--help` is the exception. It parses as an error of the kind that means *print this*,
/// and what it would print is a page: caught here, or clap's help lands on the alternate
@@ -2520,6 +2565,19 @@ impl Board {
.map(str::to_string)
}
/// The usage line of the command the prompt's line names, for the row to draw in place
/// of the keys.
///
/// Derived on every draw and held nowhere, the way `completion` is: what is on the row
/// is a function of what is in the line, so the two cannot come to disagree and there
/// is no state to clear when the line is edited. The walk is over the clap definition
/// alone and reads nothing off the board, since a keypress must not go to disk.
fn usage(&self) -> Option<String> {
let prompt = self.prompt.as_ref()?;
let split = split_line(&prompt.line, prompt.cursor);
usage_of(&split.args)
}
/// `tab`: take what every candidate agrees on, and then step through them one press at
/// a time.
///
@@ -4499,11 +4557,19 @@ fn card_lines(card: &Card, selected: bool, width: u16) -> Vec<Line<'static>> {
/// use — the stronger fact takes the row and the weaker one gives way. Bold is what stops
/// it reading as another tag when a card carries five.
///
/// A row the column will not hold is dropped whole, the rule `corner_line` applies to a
/// corner: a cut list reads as a shorter one, and `bug` and `bugfix` truncated to the
/// same width say the same thing. A ticket with neither a campaign nor a tag spends no row
/// at all, the way a short title spends no second one, so a ticket in no campaign renders
/// exactly as it did before campaigns reached the card.
/// A row that will not hold every tag draws the ones it can and ends in `(+n)`, the count
/// of the ones it left out. No tag is ever cut in half, the rule `corner_line` applies to
/// a corner: `bug` and `bugfix` truncated to the same width say the same thing. What the
/// row may do is be short, as long as it says so — the indicator is the whole difference
/// between a list that was cut and one that reads as complete, which is why the row is
/// dropped whole when it cannot hold one tag and the indicator together. A cut list
/// without the count is the thing this must never draw. Parentheses rather than brackets,
/// which are the criteria count's two rows below, and grey like the owner and that count,
/// because it is a fact about the row rather than another tag on it.
///
/// A ticket with neither a campaign nor a tag spends no row at all, the way a short title
/// spends no second one, so a ticket in no campaign renders exactly as it did before
/// campaigns reached the card.
///
/// Each tag carries its own colour, from `tag_color`, so the same tag is the same
/// colour on every card in every column, and the campaign carries its own from
@@ -4520,21 +4586,13 @@ fn labels_line(campaign: Option<&Cell>, tags: &[String], width: u16) -> Option<L
// The space between the campaign and the first tag, which the row has to hold too.
let room = width.saturating_sub(used + usize::from(campaign.is_some()));
let row = tags
.iter()
.map(|tag| format!("#{tag}"))
.collect::<Vec<_>>()
.join(" ");
let tags: &[String] = match !row.is_empty() && row.chars().count() <= room {
true => tags,
false => &[],
};
let (tags, omitted) = tags_that_fit(tags, room);
if campaign.is_none() && tags.is_empty() {
return None;
}
let mut spans = Vec::with_capacity(tags.len() * 2 + 2);
let mut spans = Vec::with_capacity(tags.len() * 2 + 3);
if let Some(cell) = campaign {
spans
.push(span_of(cell.clone()).patch_style(Style::default().add_modifier(Modifier::BOLD)));
@@ -4547,9 +4605,70 @@ fn labels_line(campaign: Option<&Cell>, tags: &[String], width: u16) -> Option<L
spans.push(Span::styled(format!("#{tag}"), Style::default().fg(tag_color(tag).into())));
}
if omitted > 0 {
spans.push(Span::raw(" "));
spans.push(Span::styled(
omitted_label(omitted),
Style::default().fg(Color::Grey.into()),
));
}
Some(Line::from(spans))
}
/// How many tags `room` cells will hold, and how many that leaves over.
///
/// Whole tags only, single spaced, in the order the ticket carries them: the first tags
/// are the ones a reader is scanning for, and reordering them would mean the same ticket
/// reads differently in two columns of different widths.
///
/// The indicator is measured as part of the row it counts, not added to a row that was
/// already full, so the answer is the largest prefix whose tags **and** `(+n)` fit. It
/// shrinks as tags are dropped — `(+9)` for nine and `(+10)` for ten — so the fit is
/// recomputed against each candidate rather than reserved once up front, which would
/// spend a cell the row does not owe on every list of under ten.
///
/// A prefix of nothing and a count of everything is a row saying only how much it is not
/// showing, which is no use to anybody, so that case comes back as no tags at all and the
/// caller spends no row on it. Every other answer either shows every tag or says how many
/// it left out; a short list that reads as a complete one is the one thing this cannot
/// return.
fn tags_that_fit(tags: &[String], room: usize) -> (&[String], usize) {
// The whole list first, which is the common case and the only one that draws no
// indicator at all.
// The hash and the space before the next tag, less the space the first one does not pay.
let whole = tags
.iter()
.map(|tag| tag.chars().count() + 2)
.sum::<usize>()
.saturating_sub(1);
if !tags.is_empty() && whole <= room {
return (tags, 0);
}
let mut width = 0;
let mut kept = 0;
for (n, tag) in tags.iter().enumerate() {
// The space before this tag, which the first one does not pay.
width += tag.chars().count() + 1 + usize::from(n > 0);
// The space before the indicator is its own, the way the space before a tag is.
if width + 1 + omitted_label(tags.len() - n - 1).chars().count() > room {
break;
}
kept = n + 1;
}
match kept {
0 => (&[], 0),
kept => (&tags[..kept], tags.len() - kept),
}
}
/// The count of the tags a row left out, as it is drawn.
fn omitted_label(omitted: usize) -> String {
format!("(+{omitted})")
}
/// The project name as it fits beside whatever the row already carries.
///
/// The mark, the id and the blocked mark are the ticket's identity and its state, and
@@ -4766,7 +4885,13 @@ fn draw_footer(frame: &mut Frame, board: &Board, area: Rect) {
// and is asked first: an input cannot be covered, and it is the newest of the three
// things that can hold the row. Only one of the two prompts can be open at a time.
if let Some(prompt) = &board.prompt {
draw_prompt(frame, prompt, board.suggestion().as_deref(), area);
draw_prompt(
frame,
prompt,
board.suggestion().as_deref(),
board.usage().as_deref(),
area,
);
return;
}
@@ -4979,7 +5104,26 @@ const PROMPT_OPENING: &str = " :";
/// of the field rather than a field of its own, so a long command loses the offer instead
/// of pushing the keys off the row. The terminal cursor sits on its first cell, which is
/// where the cursor already was: what is under a cursor is still what will be typed over.
fn draw_prompt(frame: &mut Frame, prompt: &Prompt, suggestion: Option<&str>, area: Rect) {
///
/// **The usage line takes the keys' slot as soon as the verb resolves.** The reader knows
/// the grammar approximately — that `mv` takes a status, not whether it is a positional or
/// a flag — and in a shell fish answers that as the line is typed. `esc` and `enter` are
/// what the row gives up for it: they are two keys a reader learns once, and the synopsis
/// is the thing that is different for every verb. A refusal still wins over both, being
/// what was just said about the line that is still on the row.
///
/// It is grey, the chrome colour: it is not in the line, nothing here is a value, and the
/// reader has to tell it from what they typed at a glance. Cut to what the row leaves with
/// an ellipsis, never wrapped: the footer is one line, and a second row would reflow the
/// columns every time a verb resolved. There is always at least the keys' width for it,
/// since that width was taken off the row before the line was windowed.
fn draw_prompt(
frame: &mut Frame,
prompt: &Prompt,
suggestion: Option<&str>,
usage: Option<&str>,
area: Rect,
) {
let keys = key_hints(&[("↵", "run"), ("esc", "cancel")]);
let spent: usize = PROMPT_OPENING.chars().count()
+ KEY_GAP.chars().count()
@@ -4994,6 +5138,7 @@ fn draw_prompt(frame: &mut Frame, prompt: &Prompt, suggestion: Option<&str>, are
let (visible, at) = prompt_window(&prompt.line, prompt.cursor, room);
let mut spans = vec![Span::raw(format!("{PROMPT_OPENING}{visible}"))];
let mut drawn = PROMPT_OPENING.chars().count() + visible.chars().count();
// Only ever drawn where the cursor is at the end of the line, which is what `visible`
// then ends at, so this follows the cursor rather than landing in front of the tail of
@@ -5002,16 +5147,30 @@ fn draw_prompt(frame: &mut Frame, prompt: &Prompt, suggestion: Option<&str>, are
let left = room.saturating_sub(visible.chars().count());
let shown: String = rest.chars().take(left).collect();
if !shown.is_empty() {
drawn += shown.chars().count();
spans.push(Span::styled(shown, Style::default().fg(Color::Grey.into())));
}
}
match &prompt.refused {
Some(message) => spans.push(Span::styled(
match (&prompt.refused, usage) {
(Some(message), _) => spans.push(Span::styled(
format!("{KEY_GAP}{message}"),
Style::default().fg(Color::BrightRed.into()),
)),
None => {
(None, Some(usage)) => {
// What the row leaves after the line and the gap. Nothing at all on a terminal
// too narrow to hold a cell of it, the bargain the suggestion already takes.
let left = (area.width as usize).saturating_sub(drawn + KEY_GAP.chars().count());
if left > 0 {
let shown = match usage.chars().count() <= left {
true => usage.to_string(),
false => with_ellipsis(usage, left),
};
spans.push(Span::raw(KEY_GAP));
spans.push(Span::styled(shown, Style::default().fg(Color::Grey.into())));
}
}
(None, None) => {
spans.push(Span::raw(KEY_GAP));
spans.extend(keys);
}
@@ -6438,23 +6597,101 @@ mod tests {
assert!(!rows.iter().any(|row| row.contains('#')), "{rows:?}");
}
/// A row too wide for the column goes whole, the rule a corner follows: a cut list
/// reads as a shorter one, and bug and bugfix cut to the same width say the same
/// thing.
/// A row that holds every tag draws every tag and says nothing about a count, which
/// is the common card and the one the indicator must not appear on.
#[test]
fn a_tag_row_too_wide_for_the_column_is_dropped_whole() {
fn a_row_that_holds_every_tag_spends_nothing_saying_so() {
let dir = board_dir();
write_tagged_card(&dir, "Short", "2026-12-31", "- [ ] One", "frontend, operations");
// One character short of "#frontend #operations", and one over it.
let narrow = only_card_at(&dir, 20);
assert_eq!(narrow.len(), 4, "the row was kept: {narrow:?}");
assert!(!narrow.iter().any(|row| row.contains('#')), "{narrow:?}");
// Exactly "#frontend #operations".
let fits = only_card_at(&dir, 21);
assert_eq!(fits[2], "#frontend #operations", "{fits:?}");
}
/// One character short of the whole list, the card draws what it can and counts the
/// rest. The row used to go whole there, so a narrow column — which is exactly where
/// a reader is scanning cards for a tag — showed no tags at all.
#[test]
fn a_row_too_narrow_for_every_tag_keeps_what_fits_and_counts_the_rest() {
let dir = board_dir();
write_tagged_card(&dir, "Short", "2026-12-31", "- [ ] One", "frontend, operations");
let narrow = only_card_at(&dir, 20);
assert_eq!(narrow.len(), 5, "the row was dropped: {narrow:?}");
assert_eq!(narrow[2], "#frontend (+1)", "{narrow:?}");
}
/// Whole tags only: half a tag is a different tag, and `bug` and `bugfix` cut to the
/// same width say the same thing. So the row gives up a tag before it gives up a
/// character of one, and what it draws stays inside the column.
#[test]
fn a_cut_row_cuts_whole_tags_and_stays_inside_the_column() {
let dir = board_dir();
write_tagged_card(&dir, "Short", "2026-12-31", "- [ ] One", "cli, tui, docs, tests");
for inner in 5..=23u16 {
let rows = only_card_at(&dir, inner);
let row = rows.iter().find(|row| row.contains('#'));
let Some(row) = row else { continue };
assert!(
row.chars().count() <= inner as usize,
"past the column at {inner}: {row:?}"
);
for word in row.split_whitespace().filter(|word| word.starts_with('#')) {
assert!(
["#cli", "#tui", "#docs", "#tests"].contains(&word),
"a tag was cut at {inner}: {row:?}"
);
}
}
}
/// The count is of the tags left out, not of the tags on the ticket, and it grows as
/// the column narrows rather than standing for whatever the first cut happened to be.
#[test]
fn the_indicator_counts_the_tags_the_row_left_out() {
let dir = board_dir();
write_tagged_card(&dir, "Short", "2026-12-31", "- [ ] One", "cli, tui, docs, tests");
assert_eq!(only_card_at(&dir, 20)[2], "#cli #tui #docs (+1)");
assert_eq!(only_card_at(&dir, 16)[2], "#cli #tui (+2)");
assert_eq!(only_card_at(&dir, 11)[2], "#cli (+3)");
}
/// A row with no room for one tag beside the count goes whole, as it always did: a
/// row saying only how many tags it is not showing is no use to anybody, and a tag
/// drawn without the count would read as the ticket's whole list.
#[test]
fn a_row_too_narrow_for_one_tag_and_the_count_is_dropped_whole() {
let dir = board_dir();
write_tagged_card(&dir, "Short", "2026-12-31", "- [ ] One", "frontend, operations");
// One short of "#frontend (+1)".
let narrow = only_card_at(&dir, 13);
assert_eq!(narrow.len(), 4, "the row was kept: {narrow:?}");
assert!(!narrow.iter().any(|row| row.contains('#')), "{narrow:?}");
}
/// The count is grey like the owner and the criteria count, not a colour of its own:
/// it is a fact about the row rather than another tag on it.
#[test]
fn the_indicator_is_drawn_in_grey_rather_than_as_a_tag() {
let dir = board_dir();
write_tagged_card(&dir, "Short", "2026-12-31", "- [ ] One", "frontend, operations");
let board = one_board(&dir);
let card = board.selected().expect("no card");
let colour = card_lines(card, false, 20)
.into_iter()
.flat_map(|line| line.spans)
.find(|span| span.content == "(+1)")
.map(|span| span.style.fg)
.expect("no indicator on the row");
assert_eq!(colour, Some(Color::Grey.into()));
}
/// And a title that fits gets one row, or the second is wasted on every short
/// ticket in the column.
#[test]
@@ -8199,6 +8436,132 @@ approach";
assert_eq!(at.y, SCREEN.height - 1, "the cursor left the prompt row");
}
/// The grammar, where the key list was, as soon as the verb resolves: the reader knows
/// `mv` takes a status and not whether it is a positional or a flag, which is what a
/// shell answers as the line is typed and the board answered with nothing.
#[test]
fn the_row_shows_the_usage_of_the_command_being_typed() {
let dir = searchable();
let mut board = one_board(&dir);
board.open_prompt();
// Nothing typed yet, so there is no command to describe and the keys have the slot.
let row = footer(&board, SCREEN.width, SCREEN.height);
assert!(row.contains("esc cancel"), "{row}");
type_line(&mut board, "mv ");
let row = footer(&board, SCREEN.width, SCREEN.height);
assert!(
row.contains("mv [OPTIONS] --status <STATUS> <TICKET>"),
"the usage is not on the row: {row}"
);
assert!(
!row.contains("esc cancel"),
"the keys and the usage both took the slot: {row}"
);
// And it is the grammar of the verb in the line, not of the one typed before it.
type_line(&mut board, "1111111");
board.prompt_key(ctrl('w'), SCREEN);
for _ in 0.."mv ".len() {
board.prompt_key(typed(KeyCode::Backspace), SCREEN);
}
type_line(&mut board, "comment ");
let row = footer(&board, SCREEN.width, SCREEN.height);
assert!(row.contains("comment"), "{row}");
assert!(!row.contains("--status"), "the previous verb's usage stayed: {row}");
// Closing the prompt gives the board's own key list back.
board.prompt_key(typed(KeyCode::Esc), SCREEN);
let row = footer(&board, SCREEN.width, SCREEN.height);
assert!(row.contains("quit"), "the key list did not come back: {row}");
assert!(!row.contains("--status"), "the usage outlived the prompt: {row}");
}
/// The resolve step on its own: what a verb names, what a group's child names, and what
/// a word that names nothing yet does.
///
/// The values are clap's own rendering off the definition the parse uses, which is why
/// this asserts on flags rather than on a synopsis written out here: a table of those
/// kept beside the command would go stale the first time a flag was added, and silently,
/// since nothing but a reader typing that verb would ever see the two disagree.
#[test]
fn a_usage_is_clap_s_own_and_a_nested_command_describes_itself() {
let usage = |line: &str| {
let words: Vec<String> = line.split_whitespace().map(str::to_string).collect();
usage_of(&words)
};
let mv = usage("mv").expect("mv names a command");
assert!(mv.starts_with("mv "), "the label survived: {mv}");
assert!(mv.contains("--status <STATUS>"), "{mv}");
assert!(mv.contains("<TICKET>"), "{mv}");
// The question the ticket is about: which flag the criteria section is under.
assert!(usage("set").is_some_and(|set| set.contains("--acceptance")));
// A group's child describes itself rather than its parent, once both words are
// there. `campaign set` takes a campaign; `campaign` alone takes a command.
let group = usage("campaign").expect("campaign names a command");
assert!(group.contains("<COMMAND>"), "{group}");
let child = usage("campaign set").expect("campaign set names a command");
assert!(child.contains("<CAMPAIGN>"), "{child}");
assert!(!child.contains("<COMMAND>"), "the parent's usage was drawn: {child}");
// A second word that names no child leaves the group's own usage up, which is what
// has been typed so far.
assert_eq!(usage("campaign se"), Some(group.clone()));
// And a verb that names nothing has nothing to say about it.
assert_eq!(usage("com"), None);
assert_eq!(usage(""), None);
assert_eq!(usage_of(&[]), None);
}
/// A line half typed is the state the row is looked at in, so a verb that resolves to
/// nothing draws nothing and complains about nothing.
#[test]
fn a_half_typed_verb_shows_no_usage_and_no_complaint() {
let dir = searchable();
let mut board = one_board(&dir);
board.open_prompt();
type_line(&mut board, "com");
let row = footer(&board, SCREEN.width, SCREEN.height);
assert!(row.contains("esc cancel"), "the keys lost the slot: {row}");
assert!(refused(&board).is_none(), "a half typed verb was refused");
assert!(!row.contains("Usage"), "a label reached the row: {row}");
}
/// The footer is one row, whatever the usage is: a second row would reflow the columns
/// every time a verb resolved, which is the same reason a notice of several lines is a
/// box rather than more footer.
#[test]
fn a_usage_wider_than_the_row_is_cut_and_leaves_the_columns_alone() {
let dir = searchable();
let mut board = one_board(&dir);
// `set` has the longest synopsis in the tool, a flag per section and one per scalar.
let narrow = 60;
let before = render(&board, narrow, SCREEN.height);
board.open_prompt();
type_line(&mut board, "set ");
let after = render(&board, narrow, SCREEN.height);
assert_eq!(before.len(), after.len(), "the row count changed");
assert_eq!(
before[..before.len() - 1],
after[..after.len() - 1],
"the columns moved to make room for the usage"
);
let row = after.last().expect("no rows rendered");
assert!(row.chars().count() <= narrow as usize, "the row ran over: {row}");
assert!(row.contains('…'), "a usage too wide for the row was not cut: {row}");
assert!(row.contains(" :set "), "the line lost its cells to the usage: {row}");
}
/// The line is edited where the cursor is, not at its end, which is the difference
/// between a command line and the search prompt's append-only query.
#[test]
@@ -8969,8 +9332,21 @@ approach";
let row = footer(&board, SCREEN.width, SCREEN.height);
assert!(!row.contains(":mv"), "the head of the line held the row: {row}");
// The slot at the end of the row keeps its width whatever is typed into the line,
// which is what taking it off the row before windowing is for. `mv` resolves, so
// what holds it is the usage; a verb that resolves to nothing leaves the keys.
assert!(row.contains("mv [OPTIONS]"), "a long line pushed the usage off: {row}");
board.dismiss(SCREEN);
board.open_prompt();
type_line(&mut board, &format!("nosuchverb {}", "a".repeat(200)));
let row = footer(&board, SCREEN.width, SCREEN.height);
assert!(row.contains("esc cancel"), "a long line pushed the keys off: {row}");
board.dismiss(SCREEN);
board.open_prompt();
type_line(&mut board, &format!("mv {}", "a".repeat(200)));
let mut terminal = Terminal::new(TestBackend::new(SCREEN.width, SCREEN.height)).unwrap();
terminal.draw(|frame| draw(frame, &board)).unwrap();
assert!(
@@ -12319,7 +12695,9 @@ approach";
/// The campaign takes the row first and the tags give way, the order a corner and a
/// project label already follow: two cards in one campaign is what a reader looking
/// for a campaign is looking for, and the tags are the context around it.
/// for a campaign is looking for, and the tags are the context around it. They give
/// way a tag at a time, with the count for the ones that went, and give way whole
/// only when what the campaign left will not hold one tag and the count.
#[test]
fn the_campaign_keeps_the_row_and_the_tags_give_way() {
let dir = board_dir();
@@ -12327,11 +12705,16 @@ approach";
write_member_card(&dir, "Short", "frontend, operations", V1);
// One character short of "~v1 #frontend #operations", and one over it.
let narrow = only_card_at(&dir, 24);
assert_eq!(narrow[2], "~v1", "the tags took the row from the campaign: {narrow:?}");
let cut = only_card_at(&dir, 24);
assert_eq!(cut[2], "~v1 #frontend (+1)", "{cut:?}");
let fits = only_card_at(&dir, 25);
assert_eq!(fits[2], "~v1 #frontend #operations", "{fits:?}");
// One character short of "~v1 #frontend (+1)", where the tags have nothing left
// to give up and the campaign keeps the row alone.
let narrow = only_card_at(&dir, 17);
assert_eq!(narrow[2], "~v1", "the tags took the row from the campaign: {narrow:?}");
}
/// And a campaign the row will not hold goes whole, never cut: half a codename is a