Three rows of prose was the right default and the wrong ceiling. enter while the frame holds the selection gives it half the board, enter again gives the rows back, and pgup and pgdn go on doing what they do against whichever height it is at. Half of what the frame and the columns divide, which is the screen less the tab row and the footer. Half rather than most of it for the same reason the frame is not an overlay: the columns below are the campaign's members, and a reader inspecting the campaign has to go on seeing what it is made of. So `Chrome::campaign` is an `Option<FrameSize>` rather than a bool and `campaign_rows` takes a height, resolved in `frame_rows` because that is the one place that already has an area to take a share of, which keeps `Chrome` itself pure. Bounded at both ends, and the upper bound is the one that matters: `Constraint::Min(COLUMN_MIN_ROWS)` would take rows back from a frame that asked for too many, silently, and the frame's own measurement would then disagree with what is drawn. Floored at the collapsed height, since expanding must never shrink the frame, so a board too short to divide gives the collapsed height back rather than one nothing measured. Swept over every height from 4 to 60, tabbed and not. q does not gain a layer and the arrow keys do not take the height back. The expanded frame is the frame at its other height, not a thing laid over the board, so q goes on taking the campaign filter off from either and enter is the only key that undoes what enter did. The height outlives the selection for the same reason: it is a view of the campaign the reader chose, so the columns stay short with the selection on a card. `dismiss` and `select_card` are untouched, and two tests pin that. `enter` routes through `Board::toggle_focused` rather than in the `main.rs` arm, the rule `dismiss` and `scroll_page` follow. It was inert on the frame for free before, because `Tab::selected` hands back nothing there and `toggle_detail` had nothing to open; that answer is now the thing in the way, and AGENTS.md and `Tab::selected`'s doc are amended rather than left describing the key by what it used to do. The toggle re-clamps the frame offset through `scroll_frame(0, screen)`. A taller viewport has a smaller last offset, so where the reader was can end up past the end of the frame they just asked for, and the next pgup would count down from a number the frame never showed. Criterion 13 is not done: 2a83bd4 has not landed, so there is no tag frame to give a second height to. What it inherits is on the ticket, and all of it is generic rather than campaign-specific. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
23 lines
640 B
TOML
23 lines
640 B
TOML
[package]
|
|
name = "worklane"
|
|
version = "0.26.3"
|
|
edition = "2024"
|
|
|
|
[dependencies]
|
|
clap = { version = "4", features = ["derive"] }
|
|
anyhow = "1"
|
|
uuid = { version = "1", features = ["v4"] }
|
|
chrono = { version = "0.4", features = ["serde"] }
|
|
libc = "0.2"
|
|
# unstable-rendered-line-info for Paragraph::line_count, which is how the detail view
|
|
# knows where its text ends. Counting the wrapping by hand would only agree with the
|
|
# widget until one of us changed.
|
|
ratatui = { version = "0.29", features = ["unstable-rendered-line-info"] }
|
|
crossterm = "0.28"
|
|
clap_complete = "4.6.9"
|
|
|
|
[dev-dependencies]
|
|
assert_cmd = "2"
|
|
assert_fs = "1"
|
|
tempfile = "3"
|