(d4ce964) Record status, owner and tag changes in a history log, and bump to 0.29.0
The comments directory was already an append-only log with one event kind. It is now .worklane/history/<uuid>/, with the kind in the entry and in the filename after the stamp, so a ticket says how it got where it is and not only what was said about it. mv, chown and set --tags each write an entry after their own save and behind their own no-change return, so a refused or no-op edit records nothing. --actor is on all four writers now. An old comments directory is adopted on first access and a file with no marker reads as the comment it is, so nothing is migrated or rewritten. The log moves to src/history.rs, out of util.rs and handlers.rs, and the card's counter counts comments only: a ticket that has moved three times has not been talked about. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
a1bdb5df49
commit
f454d212a4
+24
-81
@@ -5,29 +5,10 @@ use std::io::IsTerminal;
|
||||
use std::path::Path;
|
||||
use std::sync::OnceLock;
|
||||
|
||||
/// How timestamps are written into tickets and comments, and therefore how they
|
||||
/// are read back. Shared so the writer and the reader cannot drift apart.
|
||||
/// How timestamps are written into tickets and history entries, and therefore how
|
||||
/// they are read back. Shared so the writer and the reader cannot drift apart.
|
||||
pub const TIMESTAMP_FORMAT: &str = "%Y-%m-%d %H:%M:%S";
|
||||
|
||||
/// How a comment filename is stamped.
|
||||
///
|
||||
/// Microseconds, not seconds: at second resolution two comments in the same
|
||||
/// second produced the same name and the second silently truncated the first.
|
||||
/// Fixed width, so the lexicographic sort in `read_comments` stays chronological.
|
||||
pub const COMMENT_FILE_FORMAT: &str = "%Y%m%d_%H%M%S_%6f";
|
||||
|
||||
/// Where a ticket's comments live, under the board.
|
||||
///
|
||||
/// Beside the status directories rather than among them, the way `campaigns_dir` is: a
|
||||
/// comment has no status of its own. Spelled once here, so the writer, the reader and the
|
||||
/// card's counter cannot disagree about the path.
|
||||
pub const COMMENTS_DIR: &str = "comments";
|
||||
|
||||
/// The comments directory for one ticket, named by its full uuid.
|
||||
pub fn comments_dir(board: &Path, uuid: &str) -> std::path::PathBuf {
|
||||
board.join(COMMENTS_DIR).join(uuid)
|
||||
}
|
||||
|
||||
/// The mark a card puts after its comment count.
|
||||
///
|
||||
/// A closing quotation ornament, so `2\u{275e}` reads as two things somebody said rather
|
||||
@@ -663,37 +644,6 @@ pub fn resolve_ticket(search: &str, worklane_dir: &Path) -> Result<(String, Stri
|
||||
let found = matches.remove(0);
|
||||
Ok((found.dir, found.title, found.content))
|
||||
}
|
||||
pub fn format_comments(comments: &[(String, String, String, String)]) -> String {
|
||||
format_comments_with(comments, should_use_colors())
|
||||
}
|
||||
|
||||
/// As above, with the colour decision passed in for the TUI.
|
||||
pub fn format_comments_with(
|
||||
comments: &[(String, String, String, String)],
|
||||
colored: bool,
|
||||
) -> String {
|
||||
if comments.is_empty() {
|
||||
return paint("No comments yet.", Color::Grey, colored);
|
||||
}
|
||||
|
||||
let mut result = String::new();
|
||||
result.push('\n');
|
||||
result.push_str(&paint("COMMENTS", Color::Orange, colored));
|
||||
result.push_str(&format!("\n{}\n", "─".repeat(20)));
|
||||
|
||||
for (_filename, author, time, body) in comments {
|
||||
result.push('\n');
|
||||
result.push_str(&paint(&format!("From {} ({})", author, time), Color::Cyan, colored));
|
||||
result.push('\n');
|
||||
if !body.is_empty() {
|
||||
result.push_str(" ");
|
||||
result.push_str(body);
|
||||
}
|
||||
result.push('\n');
|
||||
}
|
||||
|
||||
result
|
||||
}
|
||||
/// The parts of a ticket's body that cannot be rendered from the file alone.
|
||||
///
|
||||
/// Both are resolved against the rest of the board. The Relations section stores one
|
||||
@@ -3055,22 +3005,6 @@ pub fn display_ticket_items(items: &[TicketItem]) {
|
||||
}
|
||||
}
|
||||
|
||||
/// How many comments a ticket has, counted off the directory rather than read.
|
||||
///
|
||||
/// `.md` only, the filter `read_comments` applies, so a stray file dropped in there is
|
||||
/// not counted as something somebody wrote. A missing directory is none, which is what a
|
||||
/// ticket nobody has commented on has: no directory is created until the first comment.
|
||||
fn count_comments(board: &Path, uuid: &str) -> usize {
|
||||
let Ok(entries) = fs::read_dir(comments_dir(board, uuid)) else {
|
||||
return 0;
|
||||
};
|
||||
|
||||
entries
|
||||
.filter_map(|entry| entry.ok())
|
||||
.filter(|entry| entry.path().extension().is_some_and(|ext| ext == "md"))
|
||||
.count()
|
||||
}
|
||||
|
||||
pub fn collect_ticket_items(status_path: impl AsRef<Path>) -> Result<Vec<TicketItem>> {
|
||||
let status_path = status_path.as_ref();
|
||||
// The comments sit beside the status directories, so the board is this one's parent.
|
||||
@@ -3120,10 +3054,10 @@ pub fn collect_ticket_items(status_path: impl AsRef<Path>) -> Result<Vec<TicketI
|
||||
}),
|
||||
};
|
||||
|
||||
// The ticket's own ID field, not the filename stem: a comment directory is
|
||||
// named by the uuid the file records, which is what `comment` wrote it under.
|
||||
// The ticket's own ID field, not the filename stem: a history directory is
|
||||
// named by the uuid the file records, which is what wrote the entries under it.
|
||||
let uuid = parse_ticket_field(&content, "ID");
|
||||
let comments = board.map_or(0, |board| count_comments(board, &uuid));
|
||||
let comments = board.map_or(0, |board| crate::history::count_comments(board, &uuid));
|
||||
|
||||
Some(TicketItem {
|
||||
title,
|
||||
@@ -3853,12 +3787,13 @@ mod tests {
|
||||
);
|
||||
}
|
||||
|
||||
/// The count is a directory listing rather than a read: nothing here parses a comment,
|
||||
/// The count is a directory listing rather than a read: nothing here parses an entry,
|
||||
/// and the bodies are the detail view's business.
|
||||
///
|
||||
/// `.md` only, the filter `read_comments` applies, so a stray file dropped in there is
|
||||
/// not counted as something somebody wrote. A ticket with no directory at all has
|
||||
/// none, which is every ticket until the first comment creates one.
|
||||
/// `.md` only, the filter `read_history` applies, so a stray file dropped in there is
|
||||
/// not counted as something somebody wrote, and a mechanical entry is not counted
|
||||
/// either: the card says how many things were said about the ticket. A ticket with no
|
||||
/// directory at all has none, which is every ticket until the first entry creates one.
|
||||
#[test]
|
||||
fn collect_ticket_items_counts_the_comments_under_the_board() {
|
||||
let board = tempfile::tempdir().unwrap();
|
||||
@@ -3877,12 +3812,20 @@ mod tests {
|
||||
write(talked_about);
|
||||
write(quiet);
|
||||
|
||||
let comments = comments_dir(board.path(), talked_about);
|
||||
fs::create_dir_all(&comments).unwrap();
|
||||
fs::write(comments.join("20260823_120000_000000.md"), "**Comment**\n").unwrap();
|
||||
fs::write(comments.join("20260823_120001_000000.md"), "**Comment**\n").unwrap();
|
||||
// Not a comment, and not counted as one.
|
||||
fs::write(comments.join("notes.txt"), "scratch\n").unwrap();
|
||||
let history = crate::history::history_dir(board.path(), talked_about);
|
||||
fs::create_dir_all(&history).unwrap();
|
||||
fs::write(history.join("20260823_120000_000000_comment.md"), "**Comment**\n").unwrap();
|
||||
// No kind in the name, as everything written before the kinds existed: a comment.
|
||||
fs::write(history.join("20260823_120001_000000.md"), "**Comment**\n").unwrap();
|
||||
// A field change is history but not something somebody said, so the card's
|
||||
// counter leaves it out.
|
||||
fs::write(
|
||||
history.join("20260823_120002_000000_status.md"),
|
||||
"**Status**\nbacklog → committed\n",
|
||||
)
|
||||
.unwrap();
|
||||
// Not an entry at all, and not counted as one.
|
||||
fs::write(history.join("notes.txt"), "scratch\n").unwrap();
|
||||
|
||||
let items = collect_ticket_items(&backlog).unwrap();
|
||||
let counted = |uuid: &str| {
|
||||
|
||||
Reference in New Issue
Block a user