(d5a8a3f) Add make check, one command for fmt, clippy and the suite, and bump to 0.32.20
AGENTS.md pins `cargo fmt --check` and `cargo clippy --all-targets` as clean, and 83d31cd is what happens when only memory enforces that: fmt drifted to about 160 places across every file with the tool installed and configured by default the whole time. The decision the ticket wanted, taken: mechanise it, as one command. Not CI, which a single-author tool with no pipeline anywhere does not want, and not a hook, which is a per-clone opt-in the way `blame.ignoreRevsFile` is and so cannot be relied on either. What was missing was never a mechanism, it was one name to type: "remember to run fmt, clippy and the tests" becomes `make check`. Cheapest first, so a formatting slip is reported in a second rather than after the suite. `-D warnings` is what turns clippy's opinion into an exit code, since a warning printed into a wall of cargo output is unread rather than clean. Verified each gate fails on its own: a misformatted function and a `&Vec<u8>` parameter each exit 2 before the tests run. Completions are inside `cargo test` rather than a target of their own. d93eca6 put the check that loads the generated script into a real fish there, so "check tests, check completions" is already one command, and a second target would be a second thing to remember, which is the problem this is solving. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
b63b60eefc
commit
cd7c99fe39
@@ -5,15 +5,37 @@
|
||||
# release cannot end up half-done: no version bump left untagged, no tag without
|
||||
# a bump.
|
||||
|
||||
.PHONY: help patch minor major version release install
|
||||
.PHONY: help check patch minor major version release install
|
||||
|
||||
help:
|
||||
@echo "make check fmt, clippy and the suite, in that order"
|
||||
@echo "make patch bump $(CURRENT) -> next patch, amend into HEAD, tag"
|
||||
@echo "make minor bump $(CURRENT) -> next minor, amend into HEAD, tag"
|
||||
@echo "make major bump $(CURRENT) -> next major, amend into HEAD, tag"
|
||||
@echo "make version print the current version"
|
||||
@echo "make install cargo install --path . && worklane install-skill"
|
||||
|
||||
# The one command to run before committing. AGENTS.md pins fmt and clippy as clean and
|
||||
# 83d31cd is what happens when only memory enforces that: fmt drifted to about 160 places
|
||||
# across every file with the tool installed and configured the whole time. This is not CI,
|
||||
# which a single-author tool with no pipeline anywhere does not want, and not a hook, which
|
||||
# is a per-clone opt-in the way `blame.ignoreRevsFile` is. It is one name to type, so
|
||||
# "remember to run fmt, clippy and the tests" becomes "run make check".
|
||||
#
|
||||
# Cheapest first, so a formatting slip is reported in a second rather than after the suite.
|
||||
# `--all-targets` on clippy, matching the rule in AGENTS.md, so the tests are linted too.
|
||||
# `-D warnings` is what makes clippy's opinion an exit code: the rule says clean, and a
|
||||
# warning printed into a wall of cargo output is not clean, it is unread.
|
||||
#
|
||||
# Completions are in the suite rather than a step of their own. `cargo test` sources the
|
||||
# generated script into a real fish and asks it for candidates, so "check tests, check
|
||||
# completions" is one command already, and a second target would be a second thing to
|
||||
# remember. The fish tests skip when fish is not installed, printing that they did.
|
||||
check:
|
||||
cargo fmt --check
|
||||
cargo clippy --all-targets -- -D warnings
|
||||
cargo test
|
||||
|
||||
# Read from the [package] table of Cargo.toml, which is the version the binary
|
||||
# reports through `--version`, so it is the single source of truth. The name is
|
||||
# what finds this crate's own entry in Cargo.lock.
|
||||
|
||||
Reference in New Issue
Block a user