(55ee6e3) Complete campaigns and tags, and bump to 0.19.0
Every argument naming a campaign or a tag fell through to nothing: `campaign show <TAB>`, `assign <TAB>`, `ls --campaign <TAB>` and `ls --tag <TAB>`. Neither value had a listing a completion could parse. `campaign ls --ids` is the same flag and the same two fields as `ls --ids`, since it answers the same question about a different object. It skips the member counting the decorated listing does, because `members()` reads every ticket on the board and the caller is a shell on a keypress, and it prints nothing on an empty board where the decorated listing prints a sentence. Tags get a command rather than a mode on `ls`. `ls --tag <tag>` answers what carries a tag and cannot answer what tags exist, which is the question a grooming sweep starts from, and a `--tags` beside a `--tag` is one letter from a filter that means something else. `worklane tags` prints the tag, a tab and the count, alphabetical and case sensitive like the filter, so `bug` and `Bug` list separately and land next to each other. assets/PLAN.md used to tell the agent to count the vocabulary with a `show` per ticket; it now points here. The fish half gains `__worklane_nested_arg_of`, which matches a parent and a child, because `campaign show <TAB>` and `chown alice <TAB>` sit at the same token count and the two counting helpers cannot tell them apart. It also gains `__worklane_command_is`, which fixes a leak the campaign and tag rules would have joined. A bare `complete -c worklane -l tag` does not only complete that option's values, it tells fish the whole tool accepts `--tag`: `worklane init --<TAB>` offered `--blocked-by`, `--regression-of`, `--relates-to` and three others. `relate`'s three were already leaking that way, so all of them are scoped now rather than leaving a correctly scoped twin beside a wrong one. `__fish_seen_subcommand_from ls` is not the scope to use, since `campaign ls` is an `ls` fish has seen. The honesty tests grow to five lists and one walker, `every_argument`, since they differ only in the id they look for. Each asserts how many arguments it found, so a walker that stopped finding them fails rather than passing every assertion by never running it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
6a800fb385
commit
c65e1b4ed7
@@ -413,6 +413,47 @@ fn campaign_ls_lists_campaigns_with_their_member_counts() {
|
||||
assert!(listing.contains("v2 release | no members"), "{listing}");
|
||||
}
|
||||
|
||||
/// The machine-readable listing, the same two fields and the same shape as `ls --ids`.
|
||||
#[test]
|
||||
fn campaign_ls_ids_prints_the_id_and_the_title_tab_separated() {
|
||||
let temp = TempDir::new().unwrap();
|
||||
let _worklane = board(&temp);
|
||||
|
||||
run(&temp, &["assign", "v1 release", MEMBER]);
|
||||
|
||||
let out = run(&temp, &["campaign", "ls", "--ids"]);
|
||||
assert!(out.status.success(), "{}", stderr(&out));
|
||||
|
||||
let listing = stdout(&out);
|
||||
assert_eq!(
|
||||
listing.lines().collect::<Vec<_>>(),
|
||||
vec![
|
||||
format!("{}\tv1 release", &CAMP_A[..7]),
|
||||
format!("{}\tv2 release", &CAMP_B[..7]),
|
||||
]
|
||||
);
|
||||
|
||||
// Nothing decorated: no heading, no member count, no escape.
|
||||
assert!(!listing.contains("Campaigns:"), "{listing}");
|
||||
assert!(!listing.contains("done"), "{listing}");
|
||||
assert!(!listing.contains('\u{1b}'), "{listing}");
|
||||
}
|
||||
|
||||
/// A completion offers nothing rather than a sentence, so the empty case that prints
|
||||
/// prose for a reader has to stay out of the parsed path.
|
||||
#[test]
|
||||
fn campaign_ls_ids_says_nothing_on_a_board_with_no_campaigns() {
|
||||
let temp = TempDir::new().unwrap();
|
||||
setup_worklane(&temp);
|
||||
|
||||
let out = run(&temp, &["campaign", "ls", "--ids"]);
|
||||
assert!(out.status.success(), "{}", stderr(&out));
|
||||
assert_eq!(stdout(&out), "");
|
||||
|
||||
// The decorated listing still explains itself.
|
||||
assert!(stdout(&run(&temp, &["campaign", "ls"])).contains("No campaigns yet"));
|
||||
}
|
||||
|
||||
/// A campaign is done when it holds members and every one of them is done. An empty one
|
||||
/// is neither, which is why it reads `no members` rather than `0/0 done`.
|
||||
#[test]
|
||||
|
||||
Reference in New Issue
Block a user