(9564ac9) Show the annotation in tags ls, and bump to 0.26.4
Since tags.md there are two vocabularies, the one the file declares and the one the tickets carry, and the listing reported only the second. A tag declared and never applied was invisible, and a word somebody invented in a hurry read exactly like one the board had agreed on. Those two cases are the whole reason to declare tags at all. The listing is now the union: still alphabetical, still case sensitive, with the annotation's opening line as a third tab-separated field and a count of zero for a tag nothing carries. **The absence of the third field is what marks a carried but undeclared tag.** Nothing could be appended to the first field without a completion offering a tag that does not exist, and nothing could be added to the second without it stopping being a number. Absence costs neither, and it buys the property a marker could not have: a board with no tags.md has every tag undeclared, so it prints two fields a line, which is byte for byte what this printed before the file existed. An older completion script on a newer binary keeps working, which is the same compatibility 1db02e5 kept for the bare form. A declared tag with nothing said about it answers the placeholder rather than an empty string. An empty third field is a trailing tab and nothing else, so the one difference between declared and not would have been invisible in a terminal and in a completion alike. It is also what the file itself holds under that heading, so the field is the section's opening line either way. `TagIndex::summary` does the cut to one line, the way `CampaignRow::summary` takes one line off a description the read carries whole: the annotation is prose with paragraphs in it, and how much of it a view wants is the view's business. The two fish rules pipe through `cut -f1,3`, since fish takes everything after the *first* tab as one description and the count would otherwise land in the middle of the prose. What is left is the annotation, and a tag the board has never declared is offered with no description at all, which says what the count used to say more weakly. `cut` rather than `string replace` because columns are what is being picked, and `cut -f1` is how a script reads this listing anyway. A test pins both rules rather than the script as a whole, so a rule added later that reads `worklane tags` raw is caught. `assets/ADMIN.md` claimed a declared and unapplied tag does not appear in the listing, which is now the opposite of the truth; it lists at zero. Fixed here rather than left to f7dd1a1, which does not list that file. The same stale sentence in SKILL.md and PLAN.md is recorded on that ticket. Filed on the way past: an annotation carrying a tab splits the listing into a fourth field, 8f650fc, and the `tags set` completion offers the undeclared tags it refuses, which only became filterable now that the listing tells them apart, 193f9be. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
07c783410c
commit
5dc087d49e
+37
-4
@@ -192,14 +192,21 @@ complete -c worklane -n '__worklane_command_is ls' {campaign_flags} \
|
||||
-x -a '(worklane campaign ls --ids)'
|
||||
|
||||
# Tags come from `worklane tags` rather than from a listing of objects, since a tag has no
|
||||
# id. The count after the tab lands as fish's description, which is what makes the list
|
||||
# worth reading: it says which spelling the board actually uses.
|
||||
complete -c worklane -n '__worklane_command_is ls' {tag_flags} -x -a '(worklane tags)'
|
||||
# id. Three fields now, the tag, its count and its annotation, and fish takes everything
|
||||
# after the *first* tab as one description, so the count is dropped here rather than landing
|
||||
# in the middle of the prose. `cut` and not `string replace` because the columns are what is
|
||||
# being picked, and `cut -f1` is how a script reads this listing anyway.
|
||||
#
|
||||
# What is left is the annotation, and a tag the board carries but has never declared has
|
||||
# none: it is offered with no description at all, which is the near-duplicate the file was
|
||||
# added to catch. The count used to be the description and said the same thing more weakly.
|
||||
complete -c worklane -n '__worklane_command_is ls' {tag_flags} \
|
||||
-x -a '(worklane tags | cut -f1,3)'
|
||||
|
||||
# And `tags set` names one that is already declared, so it reads the same listing. `tags
|
||||
# add` has no rule on purpose: it takes a tag the board does not have, so the candidates
|
||||
# here are the values it refuses.
|
||||
complete -c worklane -n '{tag_nested}' -a '(worklane tags)'
|
||||
complete -c worklane -n '{tag_nested}' -a '(worklane tags | cut -f1,3)'
|
||||
|
||||
# `chown --clear` names the ticket in the flag too, since with no user to give there is
|
||||
# no second positional to put it in. Scoped to `chown`, unlike the rule above: `set`
|
||||
@@ -514,6 +521,32 @@ mod tests {
|
||||
assert!(script.contains("__worklane_first_arg_of assign"), "{script}");
|
||||
}
|
||||
|
||||
/// Every rule that reads the tag listing drops the count, because `worklane tags` prints
|
||||
/// three fields and fish takes everything after the first tab as the description. Left
|
||||
/// whole, a tag would be described as its count, a tab and its annotation.
|
||||
///
|
||||
/// Pinned per rule rather than once over the script: a rule added later that reads
|
||||
/// `worklane tags` raw is the bug this catches, and it would not show up in a single
|
||||
/// `contains`.
|
||||
#[test]
|
||||
fn every_tag_rule_takes_the_annotation_as_its_description() {
|
||||
let script = fish_dynamic();
|
||||
|
||||
let reading: Vec<&str> = script
|
||||
.lines()
|
||||
.filter(|line| line.contains("(worklane tags"))
|
||||
.collect();
|
||||
|
||||
assert_eq!(
|
||||
reading.len(),
|
||||
2,
|
||||
"expected the ls --tag rule and the tags set one: {reading:?}"
|
||||
);
|
||||
for line in reading {
|
||||
assert!(line.contains("(worklane tags | cut -f1,3)"), "{line}");
|
||||
}
|
||||
}
|
||||
|
||||
/// The one status positional and the one shell positional, which clap does not emit
|
||||
/// possible values for. Read off the enums, so a fifth status would appear here on
|
||||
/// its own.
|
||||
|
||||
Reference in New Issue
Block a user