(b8aa66b) Evaluate ticket resolution in tiers, from four characters up, and bump to 0.4.0
resolve_ticket ORed the uuid prefix, title and filename predicates into one flat list, so an exact prefix match was reported as ambiguous against any title that merely mentioned that id. Reproduced: `show 641e3d5` on a board where another ticket's title quoted it failed with "Multiple tickets found", and told the user to use the displayed id, which was the id they had just used. The three tiers are now evaluated in order and the first non-empty one wins outright, which is what AGENTS.md always claimed. The ticket also asked for prefix matching to require eight characters, and that is not implemented. The guard it replaced read short_id.len() >= 8 where short_id was always the full uuid, so it was always true and any length already worked. Eight would have regressed that: ls prints seven characters, so the id the tool displays would drop out of the uuid tier and lose to any title quoting it, which is the very bug above. MIN_ID_SEARCH is four, so a short search is still text and `show 641` remains a title search. Docs corrected in four places that all stated the eight character rule: README, AGENTS.md, the opencode tool descriptions and the kanban skill. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
e20396ce6b
commit
5a7cfeb849
@@ -485,3 +485,193 @@ fn show_renders_the_metadata_as_an_aligned_table() {
|
||||
let content = fs::read_to_string(worklane.join("backlog").join(filename)).unwrap();
|
||||
assert!(content.contains("- **Owner**: alice"));
|
||||
}
|
||||
|
||||
/// Write a ticket with an exact uuid and title, since both matter to resolution.
|
||||
fn ticket_with(worklane: &std::path::Path, status: &str, uuid: &str, title: &str, slug: &str) {
|
||||
fs::write(
|
||||
worklane.join(status).join(format!("{}_{}.md", uuid, slug)),
|
||||
format!(
|
||||
"# {}\n\n## Metadata\n\n- **ID**: {}\n- **Status**: {}\n",
|
||||
title, uuid, status
|
||||
),
|
||||
)
|
||||
.unwrap();
|
||||
}
|
||||
|
||||
fn show(temp: &TempDir, search: &str) -> std::process::Output {
|
||||
let mut cmd = Command::cargo_bin(BIN_NAME).unwrap();
|
||||
cmd.current_dir(&temp.path()).arg("show").arg(search);
|
||||
cmd.assert().get_output().clone()
|
||||
}
|
||||
|
||||
/// The bug. A flat OR of the three predicates put an exact uuid prefix and a title
|
||||
/// that merely mentions it in the same list, so the search reported as ambiguous
|
||||
/// the very id the listing had just printed.
|
||||
#[test]
|
||||
fn show_prefers_a_uuid_prefix_over_a_title_that_mentions_it() {
|
||||
let temp = TempDir::new().unwrap();
|
||||
let worklane = setup_worklane(&temp);
|
||||
|
||||
ticket_with(
|
||||
&worklane,
|
||||
"backlog",
|
||||
"641e3d5d-ef23-4213-8346-e8b0114b84e9",
|
||||
"Alpha",
|
||||
"alpha",
|
||||
);
|
||||
ticket_with(
|
||||
&worklane,
|
||||
"backlog",
|
||||
"aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee",
|
||||
"Notes on 641e3d5 regression",
|
||||
"notes",
|
||||
);
|
||||
|
||||
let out = show(&temp, "641e3d5");
|
||||
let stdout = String::from_utf8_lossy(&out.stdout);
|
||||
|
||||
assert!(out.status.success(), "{:?}", String::from_utf8_lossy(&out.stderr));
|
||||
assert!(stdout.contains("Alpha"), "{stdout:?}");
|
||||
assert!(!stdout.contains("Notes on"), "{stdout:?}");
|
||||
}
|
||||
|
||||
/// `ls` prints SHORT_ID_WIDTH characters, so pasting that back has to resolve. This
|
||||
/// is the guard against reinstating an eight character minimum.
|
||||
#[test]
|
||||
fn show_resolves_the_short_id_the_listing_prints() {
|
||||
let temp = TempDir::new().unwrap();
|
||||
let worklane = setup_worklane(&temp);
|
||||
|
||||
let uuid = "641e3d5d-ef23-4213-8346-e8b0114b84e9";
|
||||
ticket_with(&worklane, "backlog", uuid, "Alpha", "alpha");
|
||||
|
||||
let mut ls = Command::cargo_bin(BIN_NAME).unwrap();
|
||||
ls.current_dir(&temp.path()).args(["ls", "backlog"]);
|
||||
let listing = String::from_utf8(ls.assert().success().get_output().stdout.clone()).unwrap();
|
||||
|
||||
// Take the id exactly as printed, so this couples to the display width rather
|
||||
// than to a hardcoded number
|
||||
let printed = listing
|
||||
.split('(')
|
||||
.nth(1)
|
||||
.and_then(|rest| rest.split(')').next())
|
||||
.expect("no id in the listing")
|
||||
.to_string();
|
||||
assert!(printed.len() < 8, "the listing prints {} chars", printed.len());
|
||||
|
||||
// A decoy whose title quotes that id. Without it the search would still land on
|
||||
// Alpha through the filename tier, since the filename contains the uuid, and the
|
||||
// test would pass under a minimum longer than the printed id.
|
||||
ticket_with(
|
||||
&worklane,
|
||||
"backlog",
|
||||
"aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee",
|
||||
&format!("Notes on {} regression", printed),
|
||||
"notes",
|
||||
);
|
||||
|
||||
let out = show(&temp, &printed);
|
||||
let stdout = String::from_utf8_lossy(&out.stdout);
|
||||
assert!(out.status.success(), "{printed} did not resolve");
|
||||
assert!(stdout.contains("Alpha"), "{stdout:?}");
|
||||
assert!(!stdout.contains("Notes on"), "{stdout:?}");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn show_resolves_a_four_character_uuid_prefix() {
|
||||
let temp = TempDir::new().unwrap();
|
||||
let worklane = setup_worklane(&temp);
|
||||
|
||||
ticket_with(
|
||||
&worklane,
|
||||
"backlog",
|
||||
"641e3d5d-ef23-4213-8346-e8b0114b84e9",
|
||||
"Alpha",
|
||||
"alpha",
|
||||
);
|
||||
|
||||
let out = show(&temp, "641e");
|
||||
assert!(out.status.success());
|
||||
assert!(String::from_utf8_lossy(&out.stdout).contains("Alpha"));
|
||||
}
|
||||
|
||||
/// Below four characters the search is text, so it must not be read as a prefix
|
||||
/// matching a large slice of the board.
|
||||
#[test]
|
||||
fn show_treats_a_search_below_four_characters_as_text() {
|
||||
let temp = TempDir::new().unwrap();
|
||||
let worklane = setup_worklane(&temp);
|
||||
|
||||
ticket_with(
|
||||
&worklane,
|
||||
"backlog",
|
||||
"641e3d5d-ef23-4213-8346-e8b0114b84e9",
|
||||
"Alpha",
|
||||
"alpha",
|
||||
);
|
||||
ticket_with(
|
||||
&worklane,
|
||||
"backlog",
|
||||
"aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee",
|
||||
"Notes on 641 regression",
|
||||
"notes",
|
||||
);
|
||||
|
||||
// "641" prefixes Alpha's uuid, but it is too short to be read as one, so the
|
||||
// title match is the only match
|
||||
let out = show(&temp, "641");
|
||||
let stdout = String::from_utf8_lossy(&out.stdout);
|
||||
|
||||
assert!(out.status.success(), "{:?}", String::from_utf8_lossy(&out.stderr));
|
||||
assert!(stdout.contains("Notes on"), "{stdout:?}");
|
||||
assert!(!stdout.contains("Alpha"), "{stdout:?}");
|
||||
}
|
||||
|
||||
/// The last tier earns its place: it reaches the middle of a uuid, which the prefix
|
||||
/// tier cannot.
|
||||
#[test]
|
||||
fn show_falls_back_to_the_filename_for_a_mid_uuid_substring() {
|
||||
let temp = TempDir::new().unwrap();
|
||||
let worklane = setup_worklane(&temp);
|
||||
|
||||
ticket_with(
|
||||
&worklane,
|
||||
"backlog",
|
||||
"641e3d5d-ef23-4213-8346-e8b0114b84e9",
|
||||
"Alpha",
|
||||
"alpha",
|
||||
);
|
||||
|
||||
let out = show(&temp, "ef23");
|
||||
assert!(out.status.success());
|
||||
assert!(String::from_utf8_lossy(&out.stdout).contains("Alpha"));
|
||||
}
|
||||
|
||||
/// Tiering removes false ambiguity across tiers, not real ambiguity inside one.
|
||||
#[test]
|
||||
fn show_still_reports_ambiguity_within_the_uuid_tier() {
|
||||
let temp = TempDir::new().unwrap();
|
||||
let worklane = setup_worklane(&temp);
|
||||
|
||||
ticket_with(
|
||||
&worklane,
|
||||
"backlog",
|
||||
"5eeddeed-1111-2222-3333-444444444444",
|
||||
"Beta",
|
||||
"beta",
|
||||
);
|
||||
ticket_with(
|
||||
&worklane,
|
||||
"backlog",
|
||||
"5eedbeef-9999-8888-7777-666666666666",
|
||||
"Gamma",
|
||||
"gamma",
|
||||
);
|
||||
|
||||
let out = show(&temp, "5eed");
|
||||
let stderr = String::from_utf8_lossy(&out.stderr);
|
||||
|
||||
assert!(!out.status.success());
|
||||
assert!(stderr.contains("Multiple tickets found"), "{stderr:?}");
|
||||
assert!(stderr.contains("Beta") && stderr.contains("Gamma"), "{stderr:?}");
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user