(2733b10) Colour the history block, and indent a comment's body deeper, and bump to 0.31.3
The block shipped with three painted things: the heading, the kind label and the actor with its timestamp as one cyan span. Every value in it was plain, so a status entry drew two status names in no colour while the same names are orange in the metadata table three lines above, and a tags entry drew its tags without the slots every other view gives them. The kind label is now grey, as chrome that names a row. It was orange, which means Status everywhere else, so an `owner` or `tags` label claimed a meaning belonging to the value beside it. `From` on a comment's author line goes grey for the same reason. Each value takes the meaning its field carries in the metadata table: status orange, tags through the same `tag_cells` the Tags field uses, a campaign codename through `tag_color` bare the way `Codename` is, an owner plain, and `_Not set_`, `_None_` and `_missing_` grey. The separator is a constant beside `change`, with `split_change` next to it, so the writer and the reader cannot disagree about what divides the two halves. The actor is drawn through `tag_color`, so one writer is one colour in every entry it wrote, and cyan goes back to meaning the timestamp alone. A comment's body moves to four spaces and the author line stays at column 0, so an indented line is somebody's own words and a line of values at column 0 is the tool reporting itself. The padding is still measured on the unpainted label, now pinned with the alignment test running both ways. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
ab337ca7f8
commit
45b513bdce
+15
-2
@@ -1006,7 +1006,11 @@ fn metadata_value_cells(name: &str, value: &str, campaign: &[Cell]) -> Vec<Cell>
|
||||
/// holds come back unchanged. `bug, cli` and `bug,cli` are both written by hand at some
|
||||
/// point, and a cell that normalised them would be the display quietly disagreeing with
|
||||
/// the file it is showing.
|
||||
fn tag_cells(value: &str) -> Vec<Cell> {
|
||||
///
|
||||
/// Shared with the history block, which draws the two halves of a tags entry through it:
|
||||
/// a tag list is a tag list wherever it is printed, and the alternative was a second
|
||||
/// splitter that would drift from this one the first time either changed.
|
||||
pub(crate) fn tag_cells(value: &str) -> Vec<Cell> {
|
||||
let mut cells = Vec::new();
|
||||
|
||||
for (index, piece) in value.split(',').enumerate() {
|
||||
@@ -1091,6 +1095,15 @@ pub const NOT_SET: &str = "_Not set_";
|
||||
/// distinction `add` already makes and clearing has to keep.
|
||||
pub const NONE: &str = "_None_";
|
||||
|
||||
/// What stands in for something the board no longer holds.
|
||||
///
|
||||
/// Not an unset value, so [`is_unknown_value`] does not read it: a field pointing at a
|
||||
/// campaign that has been removed is set, and what it is set to is gone. Drawn in the
|
||||
/// same grey all the same, which is what it shares with an unset value and why the
|
||||
/// spelling is a constant — the relations block writes it, `assign` records it in a
|
||||
/// history entry, and the two have to be the same word for the third place to paint it.
|
||||
pub const MISSING: &str = "_missing_";
|
||||
|
||||
/// Whether a field holds one of the two markers that mean it holds nothing.
|
||||
///
|
||||
/// The two constants and nothing else. `-None-` and `-Not set-` were accepted here from
|
||||
@@ -2247,7 +2260,7 @@ pub fn reference_cells(uuid: &str, name: Option<&str>) -> Vec<Cell> {
|
||||
|
||||
match name {
|
||||
Some(name) => cells.push(Cell::plain(name)),
|
||||
None => cells.push(Cell::colored("_missing_", Color::Grey)),
|
||||
None => cells.push(Cell::colored(MISSING, Color::Grey)),
|
||||
}
|
||||
|
||||
cells
|
||||
|
||||
Reference in New Issue
Block a user