(001b639) Show the comment count on a board card, and bump to 0.24.1
A card had four corners and none of them said whether anybody had written anything on the ticket. Finding out meant opening the detail view or running `show`, which is the question the board exists to answer before you commit to a card rather than after. The count goes in the bottom right, left of the criteria count. Both are about the ticket rather than about the reader, and the criteria count is what that corner has always been: this is what has been added beside it, so it is what sits further from the edge and what goes first when the column is narrow. How far along a ticket is outranks whether somebody has said something about it. `corner_line` takes the whole right-hand group now instead of one span, and the group gives up its items from the front until what is left fits. With one item that is exactly the old behaviour, which is what the top row still wants, so `due_span` returns a `Span` rather than the `Option<Span>` it only ever had to satisfy the signature. The single space between items lives in `corner_line` beside the gap arithmetic, not in the caller: the same reason `column_areas` is shared between the draw and `follow_selection`, that geometry reproduced by hand drifts from the draw. `comments` is a field on `TicketItem`, filled where `criteria` and `tags` already are, and it is the one entry on that pass that costs a directory listing rather than coming off content in hand. So it is counted, never read: `.md` only, the filter `read_comments` applies, and no body is opened, because a count needs none of them. The alternative was a `read_dir` per ticket per frame. `collect_ticket_items` derives the board from `status_path.parent()` rather than taking it as a second argument. Every caller joins a status onto a board it already holds, and two arguments would let a status directory from one board arrive with the comments of another. `comments_dir` now spells that path once for the writer, the reader and the counter, the way `campaigns_dir` does for its directory. Zero draws nothing, not a `0` and not a blank cell held open. An uncommented card is the row it has always been, down to the spacing, which is pinned exactly rather than by a `contains`. The mark is U+275E, a Dingbat, and the choice is about arithmetic as much as reading. U+1F4AC SPEECH BALLOON is emoji presentation and East Asian Width Wide, so it draws two cells where `spans_width` counts one character and every corner on the card lands a cell out. U+1F5E8 LEFT SPEECH BUBBLE is text presentation and Neutral but sits in a pictograph block most terminal fonts leave as tofu. This one has the coverage the priority meter's Geometric Shapes have. Cyan, and the only coloured thing on a row whose owner and criteria count are grey: two counts side by side otherwise read as one number in brackets and another that lost its brackets. The no-per-draw test takes the comments directory away after the board is built, and is paired with one that adds a comment and reloads, because a count that never asked the filesystem again would pass the first by never changing at all. The digest already moved on a new comment, so the reload is what recounts. Patch rather than minor: the corner was already two numbers and a mark, and this settles what it says rather than adding a view. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
50e67483d8
commit
154ffbdeb3
+2
-2
@@ -445,7 +445,7 @@ pub fn cmd_show(search: &str, worklane_dir: &Path) -> Result<()> {
|
||||
println!("\n{}", content_trim_colored(&content, &resolved));
|
||||
|
||||
if ticket_uuid != "_Not set_" {
|
||||
let comments_dir = worklane_dir.join("comments").join(&ticket_uuid);
|
||||
let comments_dir = comments_dir(worklane_dir, &ticket_uuid);
|
||||
let comments = read_comments(&comments_dir)?;
|
||||
let formatted = format_comments(&comments);
|
||||
println!("{}", formatted);
|
||||
@@ -731,7 +731,7 @@ pub fn cmd_comment(
|
||||
return Err(anyhow!("Could not determine ticket ID."));
|
||||
}
|
||||
|
||||
let comments_dir = worklane_dir.join("comments").join(&ticket_uuid);
|
||||
let comments_dir = comments_dir(&worklane_dir, &ticket_uuid);
|
||||
fs::create_dir_all(&comments_dir)?;
|
||||
|
||||
let stem = Local::now().format(COMMENT_FILE_FORMAT).to_string();
|
||||
|
||||
Reference in New Issue
Block a user