From f9c572116d7d72c6dfb0639ca51946c748747607 Mon Sep 17 00:00:00 2001 From: Andy Meneely Date: Tue, 5 Aug 2014 22:51:43 -0400 Subject: [PATCH] Properly suppressing output and testing progress bar --- lib/squib/progress.rb | 6 ++++-- spec/samples_run_spec.rb | 2 ++ spec/spec_helper.rb | 2 -- squib.gemspec | 1 + 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/lib/squib/progress.rb b/lib/squib/progress.rb index eb7bfa4..664d594 100644 --- a/lib/squib/progress.rb +++ b/lib/squib/progress.rb @@ -6,7 +6,9 @@ module Squib # @api private class DoNothing def increment - #do nothing! + end + + def finish end end @@ -22,7 +24,7 @@ module Squib end def start(title="", total=100, &block) - if @enabled && !(ENV['IN_TEST'].eql? "true") + if @enabled @bar = ProgressBar.create(title: title, total: total, format: '%t <%B> %p%% %a') yield(@bar) @bar.finish diff --git a/spec/samples_run_spec.rb b/spec/samples_run_spec.rb index 985dcbf..ba1ca12 100644 --- a/spec/samples_run_spec.rb +++ b/spec/samples_run_spec.rb @@ -6,6 +6,8 @@ describe Squib do context "all samples run without error" do it "should execute with no errors" do + p = double("ProgressBar") + allow(ProgressBar).to receive(:create).and_return(Squib::DoNothing.new) samples = File.expand_path('../samples', File.dirname(__FILE__)) Dir["#{samples}/**/*.rb"].each do |sample| Dir.chdir(samples) do #to save to _output diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 280ac9d..82e0839 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,8 +1,6 @@ require 'simplecov' require 'coveralls' -ENV['IN_TEST']="true" - SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[ SimpleCov::Formatter::HTMLFormatter, Coveralls::SimpleCov::Formatter diff --git a/squib.gemspec b/squib.gemspec index 8a6b947..4bdc479 100644 --- a/squib.gemspec +++ b/squib.gemspec @@ -37,6 +37,7 @@ Gem::Specification.new do |spec| spec.add_development_dependency "bundler", "~> 1.6" spec.add_development_dependency "rake" spec.add_development_dependency "rspec", "~> 3.0" + spec.add_development_dependency "rspec-mocks", "~> 3.0" spec.add_development_dependency "redcarpet", '~> 3.1.2' spec.add_development_dependency "github-markup", '~> 1.2.1' spec.add_development_dependency "yard"