cleanup of a few tested/resolved todos
parent
08d14689f2
commit
ebb33661c3
|
|
@ -223,7 +223,6 @@ where
|
||||||
// clear the ram with the background color
|
// clear the ram with the background color
|
||||||
let color = self.background_color.get_byte_value();
|
let color = self.background_color.get_byte_value();
|
||||||
|
|
||||||
//TODO: this is using a big buffer atm, is it better to just loop over sending a single byte?
|
|
||||||
self.interface.cmd(spi, Command::WRITE_RAM)?;
|
self.interface.cmd(spi, Command::WRITE_RAM)?;
|
||||||
self.interface.data_x_times(spi, color, WIDTH / 8 * HEIGHT)
|
self.interface.data_x_times(spi, color, WIDTH / 8 * HEIGHT)
|
||||||
}
|
}
|
||||||
|
|
|
||||||
|
|
@ -222,7 +222,6 @@ where
|
||||||
// clear the ram with the background color
|
// clear the ram with the background color
|
||||||
let color = self.background_color.get_byte_value();
|
let color = self.background_color.get_byte_value();
|
||||||
|
|
||||||
//TODO: this is using a big buffer atm, is it better to just loop over sending a single byte?
|
|
||||||
self.interface.cmd(spi, Command::WRITE_RAM)?;
|
self.interface.cmd(spi, Command::WRITE_RAM)?;
|
||||||
self.interface.data_x_times(spi, color, WIDTH / 8 * HEIGHT)
|
self.interface.data_x_times(spi, color, WIDTH / 8 * HEIGHT)
|
||||||
}
|
}
|
||||||
|
|
|
||||||
|
|
@ -55,7 +55,7 @@ use interface::DisplayInterface;
|
||||||
use traits::{InternalWiAdditions, RefreshLUT, WaveshareDisplay};
|
use traits::{InternalWiAdditions, RefreshLUT, WaveshareDisplay};
|
||||||
|
|
||||||
//The Lookup Tables for the Display
|
//The Lookup Tables for the Display
|
||||||
mod constants; //TODO: Limit to crate::drawing
|
mod constants;
|
||||||
pub use self::constants::*;
|
pub use self::constants::*;
|
||||||
|
|
||||||
use color::Color;
|
use color::Color;
|
||||||
|
|
@ -278,9 +278,6 @@ where
|
||||||
self.interface
|
self.interface
|
||||||
.data_x_times(spi, color_value, WIDTH / 8 * HEIGHT)?;
|
.data_x_times(spi, color_value, WIDTH / 8 * HEIGHT)?;
|
||||||
|
|
||||||
//TODO: Removal of delay. TEST!
|
|
||||||
//self.delay_ms(2);
|
|
||||||
|
|
||||||
self.interface
|
self.interface
|
||||||
.cmd(spi, Command::DATA_START_TRANSMISSION_2)?;
|
.cmd(spi, Command::DATA_START_TRANSMISSION_2)?;
|
||||||
self.interface
|
self.interface
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue